Remove parameters from collectd::install class #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juniorsysadmin
force-pushed
the
install-params-remove
branch
from
e9c1286 to
7d4ef66
Compare
juniorsysadmin
changed the title
bastelfreak
reviewed
Mar 30, 2018
| class { '::collectd::install': | ||
| package_install_options => $package_install_options, | ||
| } | ||
| class { '::collectd::install': } |
There was a problem hiding this comment.
this should be converted to 'contain collectd::install'?
There was a problem hiding this comment.
Yes it should, but I intend to do this in later PR as part of data type changes to init.pp
|
+1 from my side. Can you take a look at the inline comment? We should probably add this to our review guideline? |
Use variables from init.pp directly
juniorsysadmin
force-pushed
the
install-params-remove
branch
from
7d4ef66 to
417dd4e
Compare
bastelfreak
approved these changes
Mar 31, 2018
bastelfreak
approved these changes
Mar 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use variables from init.pp directly