feat: add package_keyserver parameter #746
Conversation
|
Thanks for the pr @marcdeop ! |
manifests/init.pp
Outdated
| @@ -15,6 +15,7 @@ | |||
| $minimum_version = $collectd::params::minimum_version, | |||
| $package_ensure = $collectd::params::package_ensure, | |||
| $package_install_options = $collectd::params::package_install_options, | |||
| $package_keyserver = $collectd::params::package_keyserver, | |||
There was a problem hiding this comment.
please add a datatype to the new param.
There was a problem hiding this comment.
I tipbased and added the String datatype to the package_keyserver parameter.
I was considering using Stdlib::Fqdn but is not supported by the minimum stdlib library supported by this module (4.13.1)
marcdeop
force-pushed
the
paramForKeyServers
branch
from
8b0a694 to
dcf8dc5
Compare
|
@marcdeop can you bump the version of stdlib in one commit and use Stdlib::Fqdn in the existing commit? Bumping it is fine. |
|
@bastelfreak is there anything blocking this PR from being merged? |
|
As written in the last comment: |
|
Thanks for the reminder about this PR @hadret @bastelfreak stdlib supports Stdlib::Fqdn as seen here but apparently the support is only on the master branch. The relevant PR was merged after the latest release (4.24.0) was published. Should we just go ahead and merge this PR and at the same type create an issue to handle the stdlib::fqdn type as soon as its released by puppetlabs-stdlib? |
|
Ah shit. I thought it's already released. I will merge this one as is. Can you spin up a new PR that uses the fqdn type, but with a comment that it requires a new stdlib release? |
|
Done: #759 |
We have noticed sometimes puppet fails to provision our servers due to failing connectivity to pgp.mit.edu.
This MR allows you to choose the keyserver in case such an event happens.
Thanks to Erasys GmbH