Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zookeeper tests #698

Merged
merged 3 commits into from
Oct 23, 2017
Merged

Fix zookeeper tests #698

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
113ba77
use correct datatype in zookeeper tests
bastelfreak Oct 23, 2017
b5f8f3d
convert zookeeper tests to rspec-puppet-facts
bastelfreak Oct 23, 2017
2a0a258
use correct resource names in zookeeper tests
bastelfreak Oct 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 29 additions & 26 deletions spec/classes/collectd_plugin_zookeeper_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,36 +1,39 @@
require 'spec_helper'

describe 'collectd::plugin::zookeeper', type: :class do
let :facts do
{
osfamily: 'RedHat',
collectd_version: '5.5.0',
operatingsystemmajrelease: '7',
python_dir: '/usr/local/lib/python2.7/dist-packages'
}
end
on_supported_os(test_on).each do |os, facts|
context "on #{os} " do
let :facts do
facts
end

context ':ensure => present and :zookeeper_host => \'myhost\'' do
let :params do
{ zookeeper_host: 'myhost', zookeeper_port: '2181' }
end
options = os_specific_options(facts)

it 'Will create /etc/collectd.d/10-zookeeper.conf' do
is_expected.to contain_file('write_riemann.load').with(ensure: 'present')
is_expected.to contain_file('write_riemann.load').with(path: '/etc/collectd.d/10-zookeeper.conf')
is_expected.to contain_file('write_riemann.load').with(content: %r{Host "myhost"})
is_expected.to contain_file('write_riemann.load').with(content: %r{Port "2181"})
end
end
context ":ensure => present and :zookeeper_host => 'myhost'" do
let :params do
{ zookeeper_host: 'myhost', zookeeper_port: '2181' }
end

context ':ensure => absent' do
let :params do
{ zookeeper_host: ['myhost'], ensure: 'absent' }
end
it "Will create #{options[:plugin_conf_dir]}/10-zookeeper.load" do
is_expected.to contain_file('zookeeper.load').with(ensure: 'present')
is_expected.to contain_file('zookeeper.load').with(path: "#{options[:plugin_conf_dir]}/10-zookeeper.conf")
is_expected.to contain_file('zookeeper.load').with(content: %r{Host "myhost"})
is_expected.to contain_file('zookeeper.load').with(content: %r{Port "2181"})
end
end

context ':ensure => absent' do
let :params do
{ zookeeper_host: 'myhost', ensure: 'absent' }
end

it 'Will not create ' do
is_expected.to contain_file('zookeeper.load').with(ensure: 'absent',
path: '/etc/collectd.d/10-zookeeper.conf')
it 'Will not create ' do
is_expected.to contain_file('zookeeper.load').with(
ensure: 'absent',
path: "#{options[:plugin_conf_dir]}/10-zookeeper.conf"
)
end
end
end
end
end