-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rspec-puppet-facts integration #673
Conversation
this got pulled out from #672 |
dc90226
to
ebb92fa
Compare
643e80c
to
595dc44
Compare
b818ee5
to
74bc614
Compare
spec tests itself are fine, but they are failling because they take too much time. I'm not sure how we should deal with this. We can probably drop a huge amount of existing tests. |
Hi the test are failing because of Travis ? If so, can this page help you ? https://docs.travis-ci.com/user/common-build-problems/#My-builds-are-timing-out They said that you can prefix your command with If it's not that, sorry to bother you. Thanks ! |
ac29389
to
c7aaf9e
Compare
@bastelfreak Instead of dropping tests, you could just test a subset of the OSes instead of all the ones from metadata.json. |
In the foreman we do this through a spec helper: https://github.com/theforeman/foreman-installer-modulesync/blob/cce7db684851ce28aad8c5af476cd77c81dbdbdf/moduleroot/spec/spec_helper.rb.erb#L21-L45 |
6ad49cb
to
8caeeef
Compare
No description provided.