Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'Redhat' to 'RedHat' when comparing against the osfamily fact #667

Merged
merged 1 commit into from
May 25, 2017

Conversation

bodgit
Copy link
Contributor

@bodgit bodgit commented May 9, 2017

I was tracking down why we had forked our own copy of this module and found one of the changes was simply changing the case of Redhat to RedHat in some common places. Before I remembered that Puppet helpfully compares strings case insensitively I updated all occurrences given the module uses both forms throughout. Should Puppet ever change its behaviour the latter form matches exactly what facter returns.

To keep my employers legal team happy, I have to include the following:

This contribution is provided 'as is' and without any warranty or guarantee of any kind, express or implied, including in relation to its quality, suitability for a particular purpose or non-infringement. To the extent permitted by law, in no event shall the creator of this contribution be liable for any claim, damage or other liability, whether arising in contract, tort or otherwise, arising out of or in connection with this contribution.

Both forms are used in the module, `RedHat` is correct even though
Puppet helpfully compares case insensitively.
@oranenj
Copy link
Contributor

oranenj commented May 25, 2017

The acceptance tests failing doesn't seem to be because of these changes... Hmm.

@oranenj
Copy link
Contributor

oranenj commented May 25, 2017

I'll try re-running them.

@oranenj oranenj changed the title s/Redhat/RedHat/ Change 'Redhat' to 'RedHat' when comparing against the osfamily fact May 25, 2017
@oranenj oranenj merged commit 75b28f0 into voxpupuli:master May 25, 2017
@oranenj
Copy link
Contributor

oranenj commented May 25, 2017

I changed the title to be a bit more descriptive as it may appear in the changelog. Thanks!

@oranenj oranenj added the enhancement New feature or request label May 25, 2017
@bodgit
Copy link
Contributor Author

bodgit commented May 25, 2017

Yes, this and my other two PR's seem to have failed with the same unrelated error.

@bodgit bodgit deleted the redhat branch May 25, 2017 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants