Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Redis plugin package if needed #666

Merged
merged 1 commit into from
Jul 19, 2017
Merged

Conversation

bodgit
Copy link
Contributor

@bodgit bodgit commented May 9, 2017

I found the collectd-redis sub-package wasn't being installed when I included the plugin so I added the logic based on some of the other plugins. I also refactored the code to use Puppet 4 data types and tidied up the template slightly.

To keep my employers legal team happy, I have to include the following:

This contribution is provided 'as is' and without any warranty or guarantee of any kind, express or implied, including in relation to its quality, suitability for a particular purpose or non-infringement. To the extent permitted by law, in no event shall the creator of this contribution be liable for any claim, damage or other liability, whether arising in contract, tort or otherwise, arising out of or in connection with this contribution.

Also refactor to use Puppet 4 data types.
@oranenj
Copy link
Contributor

oranenj commented May 25, 2017

Seems fine to me. Re-running the test suite...

@oranenj oranenj merged commit c4bb4e3 into voxpupuli:master Jul 19, 2017
@oranenj
Copy link
Contributor

oranenj commented Jul 19, 2017

Our tests are finally somewhat non-broken, so I'll just merge this to get things rolling again. Seems safe enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants