Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

df: add devices parameter #646

Merged
merged 1 commit into from
Feb 12, 2017
Merged

df: add devices parameter #646

merged 1 commit into from
Feb 12, 2017

Conversation

maage
Copy link
Contributor

@maage maage commented Feb 9, 2017

df plugin has had Device parameter about 10 years,
https://collectd.org/documentation/manpages/collectd.conf.5.shtml#plugin_df
https://collectd.org/wiki/index.php/Plugin:DF
add support for it as devices parameter

vinzent
vinzent approved these changes Feb 10, 2017
View reviewed changes
Copy link

@vinzent vinzent left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not a user of this module. but looks good to me. adds a spec test too. does not introduce a breaking change.

@vinzent vinzent added the enhancement New feature or request label Feb 10, 2017
@bastelfreak
Copy link
Member

Thanks @maage!

@bastelfreak bastelfreak merged commit be13190 into voxpupuli:master Feb 12, 2017
@maage maage deleted the df-by-device branch February 14, 2017 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinzent vinzent vinzent approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maage @bastelfreak @vinzent