Fix for issue #552 including acceptance tests

[jskarpe]

Adding Docker nodesets for
Debian 7/8
Ubuntu 12/14/16
Ommiting CentOS 6/7 due to bug

[jskarpe]

Seems Travis needs to retry on Debian

[jskarpe]

Fixes #552 with acceptance tests to prove it

[daenney]

This is way way way too many commits. Please do some work to rewrite history in much more processable and contained sets of commits.

Also, the changes to .travis.yml might get module synced away.

[jskarpe]

I did a rebase from master. Apparently incorrectly

[daenney]

I'm not sure the Travis+Docker changes is something we want to do right now. This is going to dramatically slow down tests, it's adding 9 tests to the matrix which almost doubles the matrix size.

[jskarpe]

The module was unusable on CentOS 6 and 7 for instance. The added tests would ensure that doesn't happen again

[jskarpe]

Not sure I agree with "dramatically" though? Spec test on Ruby 2.3.1 is already 4 minutes, which is longer than most of the Beaker tests. In my opinion the Beaker tests have more value than multiple ruby versions

[daenney]

It's at worst 9x~3m that get added to the test time when it's busy and things can't get scheduled in parallel, That's almost 20 minutes extra wait time, in practice it's probably around 10m.

I agree that we could/should remove some of the Rubies though in general. If a module doesn't have native code in it it's not that useful.

[jskarpe]

In my opinion it's still worth it :-)

[bastelfreak]

IMO we should wait with the acceptance test until voxpupuli/modulesync_config#230 is resolved. Maybe it is a good idea to add the tests from this PR in a new one?

[daenney]

The adding docker CI and revert should be squashed to just eliminate them from history.