service resource name 'collectd' should be renamed

[fnoop]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 5.0.0
• Ruby: 2.1.5p273
• Distribution: Raspbian Jessie
• Module version: 5.3.0

How to reproduce (e.g Puppet code you use)

    class { "collectd":
        purge           => true,
        recurse         => true,
        purge_config    => true,
        minimum_version => '5.4',
        manage_service  => true,
        service_name   => 'maverick-collectd',
    } ->
    service_wrapper { "collectd":
        ensure          => stopped,
        enable          => false,
    }

What are you seeing

If I set the service_name to be a custom service, I cannot then also control the collectd system service.

Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Service[collectd] is already declared in file /srv/maverick/software/maverick/manifests/puppet-modules/collectd/manifests/service.pp:9; cannot redeclare at /srv/maverick/software/maverick/manifests/init.pp:176 at /srv/maverick/software/maverick/manifests/init.pp:176:9  at /srv/maverick/software/maverick/manifests/maverick-modules/maverick_analysis/manifests/collect.pp:28 on node maverick-raspberry.home

What behaviour did you expect instead

I expect to be able to control 'collectd' system service as normal.

Output log

Any additional information you'd like to impart

This is because the name of the module service resource is set to 'collectd', so conflicting with any other use of the 'collectd' service. It could be renamed to something like 'collectd_service' to not clash.

[fnoop]

There are a lot of resources that notify the service collectd:

[dev] [mav@maverick-raspberry ~/software/maverick/manifests/puppet-modules/collectd/manifests]$ grep -r collectd |grep Service
plugin/write_graphite.pp:        notify         => Service['collectd'],
plugin/network/server.pp:    notify  => Service['collectd'],
plugin/network/listener.pp:    notify  => Service['collectd'],
plugin/filter/chain.pp:    notify         => Service['collectd'],
plugin/rabbitmq.pp:    notify  => Service['collectd'],
plugin/exec.pp:    notify         => Service['collectd'],
plugin/genericjmx.pp:    notify         => Service['collectd'],
plugin/filecount/directory.pp:    notify  => Service['collectd'],
plugin/snmp/data.pp:    notify  => Service['collectd'];
plugin/snmp/host.pp:    notify  => Service['collectd'];
plugin/apache/instance.pp:    notify  => Service['collectd'],
plugin/processes.pp:    notify         => Service['collectd'],
plugin/aggregation/aggregator.pp:    notify  => Service['collectd'],
plugin/python.pp:    notify         => Service['collectd'],
plugin/curl_json.pp:      notify  => Service['collectd'],
plugin/dbi.pp:    notify         => Service['collectd'],
plugin/mysql/database.pp:    notify  => Service['collectd'],
plugin/filter.pp:    notify  => Service['collectd'],
plugin/chain.pp:    notify  => Service['collectd'],
plugin/python/module.pp:      notify  => Service['collectd'],
plugin/postgresql.pp:    notify         => Service['collectd'],
plugin/tail/file.pp:    notify  => Service['collectd'],
plugin/curl/page.pp:    notify  => Service['collectd'],
plugin.pp:    notify  => Service['collectd'],
plugin.pp:    notify => Service['collectd'],
plugin.pp:      notify => Service['collectd'],
typesdb.pp:    notify         => Service['collectd'],

[fnoop]

@pcheliniy Do you not understand this or not agree with it? It's a valid problem.

[pcheliniy]

@fnoop I don't see this as a problem.
I'm not against such a possibility to change service name, but certainly not as the default behavior with a name different from 'collectd'.

[fnoop]

@pcheliniy That's not what this is about - this is about the puppet resource name, not the service name itself. I've changed the issue title to be clearer.

[pcheliniy]

@fnoop Thank you, sorry for that misunderstood.