File['collectd.d'] -> Concat <| tag == 'collectd' |> is too greedy

[traylenator]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 7
• puppet-collectd v13.0.0

How to reproduce (e.g Puppet code you use)

yum::versionlock{'collectd':
  ensure  => present,
  version => '5',
  before  => Class['collectd']
}                                  

contain collectd

What are you seeing

Circular dependency

$  sudo puppet apply --noop test.pp 
Error: Found 1 dependency cycle:
(Concat_file[/etc/dnf/plugins/versionlock.list] => Concat[/etc/dnf/plugins/versionlock.list] => Class[Yum::Plugin::Versionlock] => Yum::Versionlock[collectd] => Concat::Fragment[yum-versionlock-collectd] => Concat_fragment[yum-versionlock-collectd] => Concat::Fragment[yum-versionlock-collectd] => Yum::Versionlock[collectd] => Class[Collectd] => Class[Collectd::Config] => File[collectd.d] => Concat[/etc/dnf/plugins/versionlock.list] => Concat_file[/etc/dnf/plugins/versionlock.list])\nTry the '--graph' option and opening the resulting '.dot' file in OmniGraffle or GraphViz
Error: Failed to apply catalog: One or more resource dependency cycles detected in graph

The yum::versionlock is incorrectl matched by the File['collectd.d'] -> Concat <| tag == 'collectd' |>

What behaviour did you expect instead

Not a circular dependency

[traylenator]

Infuriatingly

File['collectd.d'] -> Concat <| tag == 'collectd' and path > '/etc/collectd.d/' |>

does not work , only == and != work there.

[ekohl]

I wonder if using the collectd::plugin tag would work. Then you still need to take care of collectd::typesdb, collectd::config and collectd::type, but that is more manageable.