added possibility to config storage defined types via hiera #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benibr
force-pushed
the
feature/storage_hiera_configurable
branch
from
76b687f
to
fa4ede7
Compare
benibr
force-pushed
the
feature/storage_hiera_configurable
branch
from
fa4ede7
to
e6511fd
Compare
benibr
force-pushed
the
feature/storage_hiera_configurable
branch
from
a08012c
to
2e2e566
Compare
|
added working rspec tests for all hashes |
|
thanks for the PR! |
igalic
reviewed
Sep 25, 2020
| end | ||
|
|
||
| # context 'with ndmps => { test: { username => "test", password => "foobar" }}}' do | ||
| # let(:params) do |
There was a problem hiding this comment.
@igalic Irgs, forgot that during testing.
|
i'm not happy that this was merged with 5 commits four of which could have been squashed, and a block of commented out tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #54 and #38
Since defined types cannot be configured via hiera, I added hashes to the main storage class which elements will be fed to the corresponding resources.