Switch to more strict data types #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few parameters where configured to use a String rather than a more specific data type. Switch them to Boolean / Integer accordingly.
This commit will be reverted in the next version.
smortex
force-pushed
the
fix-legacy-data-types
branch
from
29dddd6 to
0301c98
Compare
|
Excellent, thanks @smortex. |
smortex
added a commit
that referenced
this pull request
Aug 21, 2023
When data types where added in version 5.4.0 a few years ago (#117), backward compatibility with old catalog that used String for all parameters was preserved. We already did a few major releases so keeping this backward compatibility does not make sense and we can make the types more consistent by removing them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull-Request enforce stricter data types (e.g. Integer for port number).
While the change is smooth on file daemons where only
bacula-fdis used, nodes running a director must cope simultaneously with the old and the new data types. Because thebacula::directorclass create abacula::job(RestoreFiles) which is realized on the same host ; if PuppetDB already has a definition of the exported resource, it will not comply with the types requirements. As a consequence, the catalog compilation will fail and the correct "updated" resource will not replace the old invalid one in the database.To avoid this dead-end situation, the latest commit temporary adds compatibility with the types previously used. The plan would be to release a new version of the module with this code, and then revert this patch and release a new version.
Please note however that a transient invalid configuration can occur if a director is updated before the file daemons. Hopefully, as soon as the file daemons have run puppet once, the exported resources will be fixed in PuppetDB and the next update of the director will restore a valid working configuration.