Add support for current Operating Systems #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These corrections are always safe: bundle exec rubocop -a
These ones are sometimes not safe bundle exec rubocop -A
The list of supported Operating Systems is outdated. Update it and add some basic acceptance tests to ensure the code is valid.
While AIO Puppet has a well-known path to augeas lenses, non-AIO Puppet use a sysstem path that is OS-dependant. Rework the way this path is retrieved so that we can extand this easily using Hiera.
|
If we drop EOL Puppet, CI will be all green. Do we want to do a minor release first or should we proceed with removal of legacy stuff and do a major release for the next release? |
|
The module has been migrated to Vox Pupuli and not seen a release yet. I'd go for a full major release that sets a new baseline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of supported Operating Systems is outdated. Update it and add some basic acceptance tests to ensure the code is valid.
Also include: