Delete legacy .yardopts #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we don't need thefile at the moment. We don't publish html docs anymore, only the REFERENCE.md. `bundle exec rake reference` does not require the .yardopts file. I tested this at voxpupuli/puppet-lldpd#106
ekohl
approved these changes
Jul 29, 2021
|
Tracing it back, it was added in 9e927f4 and then extended in 7139ff4 but by now we've decided that generating HTML docs in the repo is a bad idea. I'm also not sure why the markup option would be needed. We don't have it in Foreman and I never noticed it. I guess it may have been needed in the past. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we don't need thefile at the moment. We don't publish html docs
anymore, only the REFERENCE.md.
bundle exec rake referencedoes notrequire the .yardopts file. I tested this at voxpupuli/puppet-lldpd#106
Fixes #733