drop deprecated wget module #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd prefer not to as it's still a dependency of other modules. |
|
(This doesn't mean we need to work on it other than eg. saying it works with puppet 7 when that comes out) |
|
can we pin down which modules, and open bugs for them to move to, i assume, archive? |
|
So what's the verdict here? |
|
with this little response, i say we kill it, and see if anyone complains |
|
@bastelfreak mind rebasing so we can merge it? |
we already deprecated it on the forge: https://forge.puppet.com/puppet/wget
|
rebased it |
|
I also opened voxpupuli/puppet-wget#119. |
ekohl
approved these changes
Nov 27, 2020
|
@alexjfisher last chance to speak up :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we already deprecated it on the forge: https://forge.puppet.com/puppet/wget