Removes deprecated argument #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ``` Error: The `Style/TrailingComma` cop no longer exists. Please use `Style/TrailingCommaInLiteral` and/or `Style/TrailingCommaInArguments` instead. ```
|
When was that changed? |
|
rubocop 0.36 IIRC |
|
Hello: Modulesync has settled on 0.35.0 for now, so this is not needed. |
|
We should look into upgrading though but yes, currently this won't affect anything: https://github.com/voxpupuli/modulesync_config/blob/master/config_defaults.yml#L32-L33 |
|
Right; unneeded at this time, but good. Does this work in 0.35.0? |
|
Merging. |
liamjbennett
added a commit
to liamjbennett/modulesync_config
that referenced
this pull request
Feb 12, 2016
jyaworski
added a commit
that referenced
this pull request
Feb 16, 2016
Fixes deprecated argument - same as #65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes