Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure newline at EOF for .yml files. #578

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Ensure newline at EOF for .yml files. #578

merged 1 commit into from
Jul 4, 2019

Conversation

pillarsdotnet
Copy link
Contributor

No description provided.

ekohl
ekohl approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When updating voxpupuli modules, I'd be in favor of going over every module. If they don't support Windows, we let it delete this file in the particular modules.

@pillarsdotnet pillarsdotnet force-pushed the fix-4 branch 3 times, most recently from da55968 to 69b0d56 Compare July 1, 2019 17:39
@pillarsdotnet pillarsdotnet force-pushed the fix-4 branch 2 times, most recently from d8709c9 to 6105acc Compare July 2, 2019 22:28
@pillarsdotnet
Copy link
Contributor Author

@Dan33l Rebased and re-signed.

@bastelfreak bastelfreak merged commit 0a0cff8 into voxpupuli:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pillarsdotnet @ekohl @bastelfreak @Dan33l