Refactor default fact loading #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ekohl can you please rebase? |
ekohl
force-pushed
the
new-default-facts
branch
from
9ff65f3 to
66d1e3c
Compare
This gets rids of the default facts because our modules do not rely on them. More importantly it switches to using add_custom_fact so we don't break the built in facts from rspec-puppet-facts.
bastelfreak
force-pushed
the
new-default-facts
branch
from
66d1e3c to
04459bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rids of the default facts because our modules do not rely on them.
More importantly it switches to using add_custom_fact so we don't break the built in facts from rspec-puppet-facts.
Tests running in voxpupuli/puppet-r10k#476. Likely to break some modules, but it's a better end result.