Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile for local tests #510

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Conversation

jkroepke
Copy link
Contributor

Running rspec tests without setup a local environment.

Just run docker build . on the root from the module to see the test results.

COPY . .

RUN bundle install
RUN bundle exec rake rubocop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle exec release_checks covers all tests, including linting which you've now skipped I think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated it

@ekohl
Copy link
Member

ekohl commented Nov 30, 2018

We should add this to the .pmtignore so it's not shipped to the forge but otherwise I'd be OK with this.

@bastelfreak
Copy link
Member

@ekohl updated it.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested and not a big fan of so many small files, but not going to block it if it makes some peoples lives easier.

@bastelfreak
Copy link
Member

I gave it a try and it worked. If any user has high experiences in docker he might come up with enhancements. Otherwise I think it's fine.

@bastelfreak bastelfreak merged commit ab61ac1 into voxpupuli:master Nov 30, 2018
@jkroepke jkroepke deleted the dockerfile branch December 1, 2018 00:08
@dhoppe
Copy link
Member

dhoppe commented Dec 3, 2018

@ekohl The number of files is not important. It is much more about the number of layers which have been reduced by using bundle exec release_checks.

@ekohl
Copy link
Member

ekohl commented Dec 5, 2018

@dhoppe I was talking about the number of files we modulesync. I want to keep that number as low as possible.

Recently you might have seen me remove a lot of them by making sure we can generate nodesets on the fly (with beaker-hostgenerator). This means we only need to update one gem rather than n modules. It also means the entire ecosystem can benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants