-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile for local tests #510
Conversation
8887704
to
3d59781
Compare
moduleroot/Dockerfile
Outdated
COPY . . | ||
|
||
RUN bundle install | ||
RUN bundle exec rake rubocop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bundle exec release_checks
covers all tests, including linting which you've now skipped I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated it
3d59781
to
5ec6582
Compare
We should add this to the |
5ec6582
to
d1bc7a0
Compare
@ekohl updated it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested and not a big fan of so many small files, but not going to block it if it makes some peoples lives easier.
I gave it a try and it worked. If any user has high experiences in docker he might come up with enhancements. Otherwise I think it's fine. |
@ekohl The number of files is not important. It is much more about the number of layers which have been reduced by using |
@dhoppe I was talking about the number of files we modulesync. I want to keep that number as low as possible. Recently you might have seen me remove a lot of them by making sure we can generate nodesets on the fly (with beaker-hostgenerator). This means we only need to update one gem rather than n modules. It also means the entire ecosystem can benefit. |
Running rspec tests without setup a local environment.
Just run
docker build .
on the root from the module to see the test results.