add pmtignore to exclude strings-docs #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs don't do any good on my puppet master. |
|
Considering docs can be generated with a rake task, I don't see why we need them pulled from the Forge |
|
Including the reason why it is excluded in the commit message would be nice. So if anybody in 6 months looks at it can see it right away from the git log. |
otherwise we will ship a huge amount of html/css docs in the module. This is maybe unwanted on a puppetserver, but also this blows up the size of the release and the forge has strict size limits, we already hit them in the past.
bastelfreak
force-pushed
the
pmtignore
branch
from
1331dc0 to
4f51770
Compare
|
good point, updated the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to discuss if we want this or not. In the past we had issues with builds that were too big so we might need to exclude the docs from releases.