Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby2.4 support + minor fix #208

Merged
merged 5 commits into from
Aug 7, 2016
Merged

Ruby2.4 support + minor fix #208

merged 5 commits into from
Aug 7, 2016

Conversation

bastelfreak
Copy link
Member

Would be totally awesome if github could show here the text of all commits.

commit e5bb33c3e5eb13c999ebded2ba6474c0c487dd7c
Author: Tim Meusel <[email protected]>
Date:   Sun Aug 7 12:15:38 2016 +0200

    use capitalized bools

    We already used it a few times in the rubocop config. this patch makes
    it now consistent.
    (We could also go with lowercase here, I just prefer capitalized)


commit 13944658ab4a7ec7d61c006423d0ab25d4cb98f9
Author: Tim Meusel <[email protected]>
Date:   Sun Aug 7 12:10:43 2016 +0200

    disable RSpec/NamedSubject for now

    this is a complicated cop that isn't easy to fix. It got introduced in
    the last rubocop-rspec release. We also use it in a lot of modules so
    fixing is time consuming and breaks our modulesync. We already disabled
    the cop in https://github.com/voxpupuli/puppet-nodejs/pull/240 which
    created the expected result.
    lot of modules


commit b8141b95717d38f0d2051d089cb87483f4369e34
Author: Tim Meusel <[email protected]>
Date:   Sun Aug 7 12:00:13 2016 +0200

    bump rubocop-rspec to 1.6

    We already test with version 1.6 and updated our configs to reflect the
    changes. There are a few new cops that could break on older
    rubocop-rspec 1.5, so we should bump the requoired version. Initial 1.6
    support came in https://github.com/voxpupuli/modulesync_config/pull/204


commit 5c1ec77c6f4e016d3019d43308b95c2cf9064585
Author: Tim Meusel <[email protected]>
Date:   Sun Aug 7 11:48:08 2016 +0200

    add testing on ruby2.4.0

    this is becomming the new Ruby version in the near future. The rolling
    release distributions will soon update to it, so we should already test
    against it. It is still under development, so we enable allow_failures
    for it. Tested in https://github.com/voxpupuli/puppet-gluster/pull/60


commit 072f5d6112825d2a87d71afa7a93af3b11562dbd
Author: Tim Meusel <[email protected]>
Date:   Sun Aug 7 11:44:32 2016 +0200

    remove uesless env attribute from allow_failures

    this isn't needed here. We specify env + rvm version in our build
    matrix. allow_failures only needs to list the rvm version. This is
    tested in https://github.com/voxpupuli/puppet-gluster/pull/60 and
    documented at
    https://docs.travis-ci.com/user/customizing-the-build/#Rows-that-are-Allowed-to-Fail

this isn't needed here. We specify env + rvm version in our build
matrix. allow_failures only needs to list the rvm version. This is
tested in voxpupuli/puppet-gluster#60 and
documented at
https://docs.travis-ci.com/user/customizing-the-build/#Rows-that-are-Allowed-to-Fail
this is becomming the new Ruby version in the near future. The rolling
release distributions will soon update to it, so we should already test
against it. It is still under development, so we enable allow_failures
for it. Tested in voxpupuli/puppet-gluster#60
We already test with version 1.6 and updated our configs to reflect the
changes. There are a few new cops that could break on older
rubocop-rspec 1.5, so we should bump the requoired version. Initial 1.6
support came in voxpupuli#204
this is a complicated cop that isn't easy to fix. It got introduced in
the last rubocop-rspec release. We also use it in a lot of modules so
fixing is time consuming and breaks our modulesync. We already disabled
the cop in voxpupuli/puppet-nodejs#240 which
created the expected result.
lot of modules
We already used it a few times in the rubocop config. this patch makes
it now consistent.
(We could also go with lowercase here, I just prefer capitalized)
@daenney
Copy link
Member

daenney commented Aug 7, 2016

We had a discussion about testing on Ruby 2.4-preview on IRC. The few people involved voiced the opinion that it's likely not helpful to us to test on 2.4-preview, especially since the language hasn't settled and any bugs surfacing here are more likely to be issues in Puppet + Ruby 2.4 but @bastelfreak feels strongly enough about it that we're merging it anyway. It doesn't hurt us since it's in the allowed_failures not blocking PRs but for those that care enough the data will be available in Travis.

@daenney daenney merged commit 10f68ee into voxpupuli:master Aug 7, 2016
@bastelfreak bastelfreak deleted the ruby24 branch August 7, 2016 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants