Ensure compatibility with ruby --enable-frozen-string-literal
#508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: https://bugs.ruby-lang.org/issues/20205 `json-schema` is used by the `rbs` gem, which is tested as part of the `ruby-core` CI, and it's failing with frozen string literals are enabled by default.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #508 +/- ##
=======================================
Coverage 90.08% 90.08%
=======================================
Files 76 76
Lines 1584 1584
=======================================
Hits 1427 1427
Misses 157 157 ☔ View full report in Codecov by Sentry. |
|
Thanks for the patch @casperisfine |
|
Thanks for the extremely timely merge :) |
|
As a maintainer I know it's annoying to be asked for a release, but in this case I arrived here because I'm trying to get So I'd owe you one if you could cut a release soon 🙏 |
casperisfine
pushed a commit
to casperisfine/rbs
that referenced
this pull request
Mar 15, 2024
Ref: https://bugs.ruby-lang.org/issues/20205 Ref: voxpupuli/json-schema#508 Since `rbs` is tested as part of ruby-core CI, it needs to be compatible with the `--enable-frozen-string-literal` option.
|
already on it :) |
|
😻 |
casperisfine
pushed a commit
to casperisfine/rbs
that referenced
this pull request
Mar 15, 2024
Ref: https://bugs.ruby-lang.org/issues/20205 Ref: voxpupuli/json-schema#508 Since `rbs` is tested as part of ruby-core CI, it needs to be compatible with the `--enable-frozen-string-literal` option.
|
considering #507 resolved too |
casperisfine
pushed a commit
to casperisfine/typeprof
that referenced
this pull request
Mar 18, 2024
Ref: https://bugs.ruby-lang.org/issues/20205 Ref: voxpupuli/json-schema#508 Since `typeprof` is tested as part of ruby-core CI, it needs to be compatible with the `--enable-frozen-string-literal` option.
casperisfine
pushed a commit
to casperisfine/typeprof
that referenced
this pull request
Mar 18, 2024
Ref: https://bugs.ruby-lang.org/issues/20205 Ref: voxpupuli/json-schema#508 Since `typeprof` is tested as part of ruby-core CI, it needs to be compatible with the `--enable-frozen-string-literal` option.
casperisfine
pushed a commit
to casperisfine/typeprof
that referenced
this pull request
Mar 18, 2024
Ref: https://bugs.ruby-lang.org/issues/20205 Ref: voxpupuli/json-schema#508 Since `typeprof` is tested as part of ruby-core CI, it needs to be compatible with the `--enable-frozen-string-literal` option.
casperisfine
pushed a commit
to casperisfine/typeprof
that referenced
this pull request
Mar 18, 2024
Ref: https://bugs.ruby-lang.org/issues/20205 Ref: voxpupuli/json-schema#508 Since `typeprof` is tested as part of ruby-core CI, it needs to be compatible with the `--enable-frozen-string-literal` option.
casperisfine
pushed a commit
to casperisfine/typeprof
that referenced
this pull request
Mar 18, 2024
Ref: https://bugs.ruby-lang.org/issues/20205 Ref: voxpupuli/json-schema#508 Since `typeprof` is tested as part of ruby-core CI, it needs to be compatible with the `--enable-frozen-string-literal` option.
casperisfine
pushed a commit
to casperisfine/typeprof
that referenced
this pull request
Mar 18, 2024
Ref: https://bugs.ruby-lang.org/issues/20205 Ref: voxpupuli/json-schema#508 Since `typeprof` is tested as part of ruby-core CI, it needs to be compatible with the `--enable-frozen-string-literal` option.
casperisfine
pushed a commit
to casperisfine/rbs
that referenced
this pull request
Mar 18, 2024
Ref: https://bugs.ruby-lang.org/issues/20205 Ref: voxpupuli/json-schema#508 Since `rbs` is tested as part of ruby-core CI, it needs to be compatible with the `--enable-frozen-string-literal` option.
mame
pushed a commit
to ruby/typeprof
that referenced
this pull request
Mar 18, 2024
Ref: https://bugs.ruby-lang.org/issues/20205 Ref: voxpupuli/json-schema#508 Since `typeprof` is tested as part of ruby-core CI, it needs to be compatible with the `--enable-frozen-string-literal` option.
mostlyobvious
added a commit
to RailsEventStore/rails_event_store
that referenced
this pull request
Jun 12, 2024
They've fixed frozen-string-literal issue. Apparently it needed a different maintainer to approve identical changes proposed one more time. voxpupuli/json-schema#507 voxpupuli/json-schema#508 Co-authored-by: Szymon Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://bugs.ruby-lang.org/issues/20205
json-schemais used by therbsgem, which is tested as part of theruby-coreCI, and it's failing with frozen string literals are enabled by default.