Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to encrypt with an RSA public key #379

Merged
merged 2 commits into from
May 10, 2024
Merged

Add support to encrypt with an RSA public key #379

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e5e1b1
Add support to encrypt with an RSA public key
cmd-ntrf May 6, 2024
87544ab
Raise error when public key is invalid
cmd-ntrf May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/hiera/backend/eyaml/encryptors/pkcs7.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,13 @@ def self.encrypt(plaintext)
LoggingHelper.trace 'PKCS7 encrypt'

public_key_pem = load_public_key_pem
public_key_x509 = OpenSSL::X509::Certificate.new(public_key_pem)
if public_key_pem.include? 'BEGIN CERTIFICATE'
public_key_x509 = OpenSSL::X509::Certificate.new(public_key_pem)
elsif public_key_pem.include? 'BEGIN PUBLIC KEY'
public_key_rsa = OpenSSL::PKey::RSA.new(public_key_pem)
public_key_x509 = OpenSSL::X509::Certificate.new
public_key_x509.public_key = public_key_rsa.public_key
end
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If neither branch of the if statement matches, does this raise an error that informs the user which types of content need to be in the .pem file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added an else clause to raise an exception to inform the user the key format is invalid to encrypt.


cipher = OpenSSL::Cipher.new('aes-256-cbc')
OpenSSL::PKCS7.encrypt([public_key_x509], plaintext, cipher, OpenSSL::PKCS7::BINARY).to_der
Expand Down