Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocop: Fix newlines, whitespace and commas #272

Merged
merged 3 commits into from
Feb 21, 2023
Merged

rubocop: Fix newlines, whitespace and commas #272

merged 3 commits into from
Feb 21, 2023

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak self-assigned this Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 0.50% // Head: 0.50% // No change to project coverage 👍

Coverage data is based on head (cc5f818) compared to base (e10e11c).
Patch coverage: 0.33% of modified lines in pull request are covered.

❗ Current head cc5f818 differs from pull request most recent head db4ba3a. Consider uploading reports for the commit db4ba3a to get more accurate results

Additional details and impacted files 
@@          Coverage Diff           @@
##           master    #272   +/-   ##
======================================
  Coverage    0.50%   0.50%           
======================================
  Files          15      15           
  Lines        2553    2553           
======================================
  Hits           13      13           
  Misses       2540    2540
Impacted Files Coverage Δ
lib/beaker-hostgenerator/cli.rb 0.00% <0.00%> (ø)
lib/beaker-hostgenerator/data.rb 0.00% <0.00%> (ø)
lib/beaker-hostgenerator/generator.rb 0.00% <ø> (ø)
lib/beaker-hostgenerator/hypervisor.rb 0.00% <ø> (ø)
lib/beaker-hostgenerator/hypervisor/hcloud.rb 0.00% <0.00%> (ø)
lib/beaker-hostgenerator/hypervisor/vmpooler.rb 0.00% <0.00%> (ø)
lib/beaker-hostgenerator/parser.rb 0.00% <0.00%> (ø)
lib/beaker-hostgenerator/roles.rb 0.00% <0.00%> (ø)
lib/beaker-hostgenerator/util.rb 0.00% <0.00%> (ø)
test/util/generator_helpers.rb 26.00% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bastelfreak bastelfreak merged commit 129b1b3 into voxpupuli:master Feb 21, 2023
@bastelfreak bastelfreak deleted the rubocop2 branch February 21, 2023 19:23
ekohl
ekohl reviewed Feb 21, 2023
View reviewed changes
lib/beaker-hostgenerator/cli.rb
@@ -74,55 +74,55 @@ def initialize(argv = ARGV.dup)
opts.on('-l',
'--list',
'List beaker-hostgenerator supported platforms, roles, and hypervisors. ' <<
'Does not produce host config.') do
'Does not produce host config.',) do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks odd. I think for https://rubydoc.info/gems/rubocop/RuboCop/Cop/Style/TrailingCommaInArguments we want comma, not consistent_comma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@sebastianrakel sebastianrakel sebastianrakel approved these changes

Assignees

@bastelfreak bastelfreak

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bastelfreak @ekohl @sebastianrakel @evgeni