Enable Rubocop in CI #268
Merged
Enable Rubocop in CI #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
commented
Feb 20, 2023
| @@ -19,6 +19,8 @@ eos | |||
| s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } | |||
| s.require_paths = ["lib"] | |||
|
|
|||
| s.required_ruby_version = Gem::Requirement.new('>= 2.4') | |||
There was a problem hiding this comment.
this is what our CI currently tests on, so I assume that's the oldest supported version.
Codecov ReportBase: 0.50% // Head: 0.50% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #268 +/- ##
======================================
Coverage 0.50% 0.50%
======================================
Files 15 15
Lines 2565 2565
======================================
Hits 13 13
Misses 2552 2552 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
smortex
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.