Drop redundant attributes from generated data #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beaker already returns the platform when packaging_platform isn't set. This means specifying if it matches is redundant.
This is not needed to specify and only increases the generated data.
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
=========================================
+ Coverage 0.51% 0.52% +0.01%
=========================================
Files 14 14
Lines 2531 2461 -70
=========================================
Hits 13 13
+ Misses 2518 2448 -70
Continue to review full report at Codecov.
|
bastelfreak
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
Looks fine to me. Maybe @GabrielNagy wants to take a look at well
GabrielNagy
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drop packaging_platform where it matches platform. Beaker already returns the platform when packaging_platform isn't set. This means specifying if it matches is redundant.
It also omits the empty entries for pe_*.