Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(IMAGES-1323) Adds RedHat 9 support #235

Merged

Conversation

mhashizume
Copy link
Contributor

A companion PR to voxpupuli/beaker#1719

@codecov
Copy link

codecov bot commented Dec 4, 2021

Codecov Report

Merging #235 (77c2a49) into master (cf879b1) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #235      +/-   ##
=========================================
- Coverage    0.51%   0.51%   -0.01%     
=========================================
  Files          14      14              
  Lines        2510    2519       +9     
=========================================
  Hits           13      13              
- Misses       2497    2506       +9     
Impacted Files Coverage Δ
lib/beaker-hostgenerator/data.rb 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf879b1...77c2a49. Read the comment docs.

Copy link
Member

@GabrielNagy GabrielNagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 👍, I also confirmed the fixtures are correct, not sure why the codecov check is failing.

@GabrielNagy GabrielNagy merged commit ca1a897 into voxpupuli:master Dec 6, 2021
@ekohl
Copy link
Member

ekohl commented Dec 6, 2021

I'd really be in favor of dropping codecov. It's obviously not doing anything useful and only generates noise. That's my general impression of codecov, but especially true here.

@joshcooper
Copy link
Contributor

Could we get a beaker-hostgenerator gem release that contains this fix? It looks like this is handled through the github action, but I wanted to ask before kicking it.

@GabrielNagy
Copy link
Member

@joshcooper I can take care of this today; the steps for releasing are documented here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants