(FM-8341) Align with changes to Cisco in NSPooler #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A draft PR of the NSPooler work is available: https://github.com/puppetlabs/nspooler/pull/164 |
mattkirby
approved these changes
Oct 7, 2019
kevpl
approved these changes
Oct 7, 2019
Improve readability while keeping existing convention
|
rebased and resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will make the naming of the Cisco hosts more clearer (denoting those that are Hardware vs Virtual Machine) and will hook into the upcoming changes to go into NSPooler to support all the physical Cisco devices used by the Network Automation Team.