(MAINT) Add locale to vmpooler Jap/French defs #160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an outcome of moving the Windows-2012r2 localised vmpooler platforms to Windows 2019. When trying to test the new BHG strings in the ci-job-configs repo using the Puppet Repo Jenkins test harness it was obvious that there were issues with the parsing of the embedded "locale" string in the BHG name.
So since BHG already supports additional Beaker variables in the definition (see the use of the "user" variable for the French platform definitions to allow Windows use a localised Administrator name) it
makes sense to properly embed the "locale" definition here for the French and Japanese platforms.
This will allow the removal of the windows2019_ja-64%7Blocale=ja%7D type string from the Puppet Agent CI job definitions.