Add global CONTRIBUTING.md #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Jan 27, 2022
|
I marked the development section as puppet specific, but I don't know yet how we should phrase the rest. Our other projects don't have a unified workflow. maybe something like 'check the readme.md for individual documentation and the used github actions' but that's not really helping people I think. |
ekohl
reviewed
Jan 27, 2022
.github/CONTRIBUTING.md
Outdated
| ### Syntax and style | ||
|
|
||
| The test suite will run [Puppet Lint](http://puppet-lint.com/) and | ||
| [Puppet Syntax](https://github.com/gds-operations/puppet-syntax) to |
There was a problem hiding this comment.
This was moved to VP so the URL is out of date.
.github/CONTRIBUTING.md
Outdated
| you must set an environment variable such as: | ||
|
|
||
| ```sh | ||
| export PUPPET_VERSION="~> 5.5.6" |
There was a problem hiding this comment.
This will change to PUPPET_GEM_VERSION
bastelfreak
force-pushed
the
CONTRIBUTING
branch
from
05e3b42 to
2f23ce4
Compare
rwaffen
approved these changes
Apr 12, 2024
ekohl
requested changes
Apr 26, 2024
bastelfreak
force-pushed
the
CONTRIBUTING
branch
3 times, most recently
from
6ef6767 to
48918d1
Compare
bastelfreak
force-pushed
the
CONTRIBUTING
branch
from
48918d1 to
0cc7b8a
Compare
kenyon
approved these changes
Aug 27, 2024
bastelfreak
force-pushed
the
CONTRIBUTING
branch
from
c6c11a6 to
69562fc
Compare
kenyon
approved these changes
Aug 27, 2024
bastelfreak
force-pushed
the
CONTRIBUTING
branch
from
f705baf to
0059f71
Compare
bastelfreak
added a commit
to bastelfreak/voxpupuli-test
that referenced
this pull request
Sep 6, 2024
This got extracted from voxpupuli/.github#1
bastelfreak
added a commit
to bastelfreak/voxpupuli-test
that referenced
this pull request
Sep 6, 2024
This got extracted from voxpupuli/.github#1
bastelfreak
added a commit
to bastelfreak/voxpupuli-test
that referenced
this pull request
Sep 6, 2024
This got extracted from voxpupuli/.github#1
bastelfreak
force-pushed
the
CONTRIBUTING
branch
3 times, most recently
from
2f677af to
1137802
Compare
This will allow us to purge it from modulesync_config.
bastelfreak
force-pushed
the
CONTRIBUTING
branch
from
1137802 to
14127c2
Compare
kenyon
approved these changes
Sep 6, 2024
jhoblitt
approved these changes
Sep 10, 2024
ekohl
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to purge it from modulesync_config.