Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Pick Open3d fix #5422

Merged
merged 1 commit into from
Jan 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements/common.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
aiofiles==0.7.0
argcomplete==1.11.0
boto3==1.17.36
boto3==1.36.2
cachetools==5.2.0
dacite==1.6.0
Deprecated==1.2.11
Expand Down
2 changes: 1 addition & 1 deletion requirements/extras.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
google-api-python-client>=1.6.5
google-cloud-storage>=1.36
httplib2<=0.15
ipywidgets>=7.5,<8
ipywidgets>=7.5
notebook>=5.3
pydicom>=2.2.0
shapely>=1.7.1
4 changes: 2 additions & 2 deletions requirements/test.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
awscli==1.37.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Align AWS SDK versions to prevent compatibility issues

The awscli==1.37.2 is from a newer version series than boto3==1.36.2. Since boto3 hasn't released 1.37.x versions yet, consider using awscli 1.36.x (like 1.36.2 or 1.36.3) to maintain version parity with boto3.

🔗 Analysis chain

Verify AWS SDK version compatibility.

The awscli==1.37.2 package might have compatibility issues with boto3==1.36.2 specified in common.txt, as they are from different AWS SDK versions. Consider aligning these versions.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check awscli and boto3 version compatibility
pip index versions awscli | grep "1.36"
pip index versions boto3 | grep "1.37"

Length of output: 34431

open3d>=0.16.0
itsdangerous==2.0.1
werkzeug>=2.0.3
pydicom<3
pytest==7.3.1
Expand All @@ -8,4 +8,4 @@ pytest-mock==3.10.0
pytest-asyncio
shapely
tensorflow==2.17.0
twine>=3
twine>=3
Loading