Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove itsdangerous pin #5403

Merged
merged 13 commits into from
Jan 21, 2025
Merged

remove itsdangerous pin #5403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6624e7b
pin open3d
sashankaryal Jan 17, 2025
6649f84
more than 16, less than 19
sashankaryal Jan 17, 2025
4171d23
pin urllib3
sashankaryal Jan 20, 2025
3439365
remove itsdangerous
sashankaryal Jan 20, 2025
4ddbcdb
test less
sashankaryal Jan 20, 2025
6239515
bring back
sashankaryal Jan 20, 2025
401a8b3
up to 18
sashankaryal Jan 20, 2025
8b4b97d
bump itsdangerous
sashankaryal Jan 20, 2025
aaac3ee
add boto
sashankaryal Jan 20, 2025
77587d7
try w new aws
sashankaryal Jan 21, 2025
b7a4810
try w more alterations
sashankaryal Jan 21, 2025
209e16f
gt or equal
sashankaryal Jan 21, 2025
b2d028c
unping ipyywidgets
sashankaryal Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements/common.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
aiofiles==0.7.0
argcomplete==1.11.0
boto3==1.17.36
boto3==1.36.2
cachetools==5.2.0
dacite==1.6.0
Deprecated==1.2.11
Expand Down
2 changes: 1 addition & 1 deletion requirements/extras.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
google-api-python-client>=1.6.5
google-cloud-storage>=1.36
httplib2<=0.15
ipywidgets>=7.5,<8
ipywidgets>=7.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Maintain version constraint for ipywidgets

The removal of the upper version bound (<8) could lead to compatibility issues as ipywidgets has undergone a major version change (current latest is 8.1.5). Since major versions often introduce breaking changes and the package has tightly coupled dependencies, it's recommended to maintain version constraints:

  • Consider using ipywidgets>=7.5,<8 to ensure stability
  • If v8 support is needed, verify compatibility with your usage first
🔗 Analysis chain

Verify compatibility with newer ipywidgets versions.

Removing the upper version bound (<8) could potentially introduce compatibility issues with newer versions of ipywidgets. While this change allows for more flexibility, it may need additional testing to ensure compatibility with the rest of the ecosystem.

Let's check for any known compatibility issues or breaking changes in newer versions:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for major version changes and dependencies of ipywidgets

# Get the latest version and its dependencies
curl -s https://pypi.org/pypi/ipywidgets/json | jq -r '.releases | keys[]' | sort -V | tail -n 1
curl -s https://pypi.org/pypi/ipywidgets/json | jq '.info.requires_dist'

# Check if this package is a dependency of other packages in the project
rg -l "ipywidgets" requirements/

Length of output: 531

notebook>=5.3
pydicom>=2.2.0
shapely>=1.7.1
4 changes: 2 additions & 2 deletions requirements/test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
awscli==1.37.2
open3d>=0.16.0
itsdangerous==2.0.1
werkzeug>=2.0.3
pydicom<3
pytest==7.3.1
Expand All @@ -8,4 +8,4 @@ pytest-mock==3.10.0
pytest-asyncio
shapely
tensorflow==2.17.0
twine>=3
twine>=3
Loading