Model evaluation panel fixes and enhancements #5281
Conversation
|
Warning Rate limit exceeded@imanjra has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 28 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThe pull request introduces enhancements to the model evaluation view in a machine learning application. New components like Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/ErrorIcon.tsx (1)
7-31: Allow the icon's color to be customized via propsThe
ErrorIconcomponent currently uses hardcoded fill colors in the SVG paths, which limits its reusability and theming capabilities. To align with Material-UI best practices and allow the icon's color to be controlled via props, consider replacing the hardcodedfillattributes withfill="currentColor".Apply this diff to update the SVG paths:
<SvgIcon width="54" height="61" viewBox="0 0 54 61" fill="none" {...props}> <path - d="M27 3.16667C34.0667 3.16667 40.6667 3.9 45.5334 5.23333C48.4667 6.03333 50 6.83333 50.6667 7.3V53.7C50.0667 54.1667 48.5334 54.9667 45.5334 55.7667C40.6667 57.1 34.0667 57.8333 27 57.8333C19.9334 57.8333 13.3334 57.1 8.46669 55.7667C5.53335 54.9667 4.00002 54.1667 3.33335 53.7V7.3C3.93335 6.83333 5.46669 6.03333 8.46669 5.23333C13.3334 3.9 19.9334 3.16667 27 3.16667ZM27 0.5C19.7334 0.5 12.8667 1.23333 7.73335 2.63333C2.86669 3.96667 0.666687 5.56667 0.666687 6.56667V54.4333C0.666687 55.4333 2.86669 57.0333 7.73335 58.3667C12.8667 59.7 19.7334 60.5 27 60.5C34.2667 60.5 41.1334 59.7 46.2667 58.3667C51.1334 57.0333 53.3334 55.4333 53.3334 54.4333V6.56667C53.3334 5.56667 51.1334 3.96667 46.2667 2.63333C41.1334 1.23333 34.2667 0.5 27 0.5Z" - fill="#FFC59B" + fill="currentColor" /> <path d="M18.2664 27.6333C14.3331 27.6333 11.0664 24.4333 11.0664 20.4333C11.0664 16.4333 14.3331 13.2999 18.2664 13.2999C22.1997 13.2999 25.3997 16.4999 25.3997 20.4333C25.3997 24.3666 22.1997 27.6333 18.2664 27.6333ZM18.2664 15.9666C15.7997 15.9666 13.7331 17.9666 13.7331 20.4999C13.7331 23.0333 15.7331 25.0333 18.2664 25.0333C20.7997 25.0333 22.7997 23.0333 22.7997 20.4999C22.7997 17.9666 20.7331 15.9666 18.2664 15.9666Z" - fill="#FFC59B" + fill="currentColor" /> <!-- Repeat for all paths --> </SvgIcon>This change allows the icon's color to be controlled by the
colorprop of theSvgIcon, enhancing reusability and consistency with theming.fiftyone/operators/builtins/panels/model_evaluation/__init__.py (1)
303-310: Consider adding logging for unsupported evaluation typesWhile the error handling is good, adding logging would help track occurrences of unsupported types in production.
if evaluation_type not in SUPPORTED_EVALUATION_TYPES: + logger.warning( + "Unsupported evaluation type: %s for key: %s", + evaluation_type, + computed_eval_key + ) ctx.panel.set_data( f"evaluation_{computed_eval_key}_error", {"error": "unsupported", "info": serialized_info}, )
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Error.tsx(1 hunks)app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/ErrorIcon.tsx(1 hunks)app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx(19 hunks)app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/utils.ts(1 hunks)fiftyone/operators/builtins/panels/model_evaluation/__init__.py(3 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/utils.ts (1)
Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/ErrorIcon.tsx (1)
Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Error.tsx (1)
Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx (1)
Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.
🪛 Biome (1.9.4)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/utils.ts
[error] 38-38: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead.
See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.
(lint/suspicious/noGlobalIsNan)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Error.tsx
[error] 6-6: Do not shadow the global "Error" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx
[error] 45-45: Do not shadow the global "Error" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
🔇 Additional comments (2)
fiftyone/operators/builtins/panels/model_evaluation/__init__.py (2)
35-35: LGTM: Well-defined constant for supported evaluation types
The constant follows proper naming conventions and includes common ML model evaluation types.
323-323: Verify serialized evaluation info structure
While using pre-serialized info is good for consistency, consider validating its structure to prevent potential issues.
| @@ -42,6 +42,7 @@ import { | |||
| } from "@mui/material"; | |||
| import React, { useEffect, useMemo, useState } from "react"; | |||
| import { useRecoilState, useSetRecoilState } from "recoil"; | |||
| import Error from "./Error"; | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Avoid shadowing the global 'Error' object
Importing Error shadows the global Error object, which can lead to confusion or unexpected behavior. Consider renaming the imported component to prevent this issue.
Apply this diff to rename the import and update its usage:
-import Error from "./Error";
+import EvaluationError from "./Error";
...
- return <Error error={evaluationError} onBack={navigateBack} />;
+ return <EvaluationError error={evaluationError} onBack={navigateBack} />;Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 Biome (1.9.4)
[error] 45-45: Do not shadow the global "Error" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
| @@ -35,7 +35,7 @@ export function getNumericDifference( | |||
| export function formatValue(value: string | number, fractionDigits = 3) { | |||
| const numericValue = | |||
| typeof value === "number" ? value : parseFloat(value as string); | |||
| if (!isNaN(numericValue)) { | |||
| if (!isNaN(numericValue) && numericValue == value) { | |||
There was a problem hiding this comment.
Use Number.isNaN instead of global isNaN
The global isNaN function performs type coercion, which can lead to unexpected results. It's safer to use Number.isNaN, which does not coerce the argument and ensures accurate checks for NaN.
Apply this diff to update the code:
-export function formatValue(value: string | number, fractionDigits = 3) {
+export function formatValue(value: string | number, fractionDigits = 3) {
const numericValue =
typeof value === "number" ? value : parseFloat(value as string);
- if (!isNaN(numericValue) && numericValue == value) {
+ if (!Number.isNaN(numericValue) && numericValue == value) {
return parseFloat(numericValue.toFixed(fractionDigits));
}
return value;
}Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 Biome (1.9.4)
[error] 38-38: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead.
See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.
(lint/suspicious/noGlobalIsNan)
| import React from "react"; | ||
| import ErrorIcon from "./ErrorIcon"; | ||
|
|
||
| export default function Error(props) { |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Avoid shadowing the global 'Error' object
Naming the component Error shadows the global Error object, which can lead to confusion or unexpected behavior. Consider renaming the component to avoid this issue.
Apply this diff to rename the component:
-export default function Error(props) {
+export default function EvaluationError(props) {
const { onBack } = props;
return (
<Stack sx={{ height: "100%", p: 2 }} spacing={1}>
...
</Stack>
);
}Also, update the component's usage and props type accordingly:
-type ErrorProps = {
+type EvaluationErrorProps = {
onBack: () => void;
error: any;
};Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 Biome (1.9.4)
[error] 6-6: Do not shadow the global "Error" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
imanjra
force-pushed
the
bugfix/me-panel-tweaks
branch
from
cf54fc2 to
f15a383
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (5)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Error.tsx (1)
26-32: Enhance accessibility with ARIA attributesThe error message should be properly labeled for screen readers.
Apply this diff to improve accessibility:
<Typography color="secondary"> + role="status" + aria-live="polite" Analyze and improve models collaboratively with your team </Typography> <Typography sx={{ fontWeight: 600 }}> + role="alert" The Model Evaluation panel currently supports only classification, detection, and segmentation evaluations </Typography>fiftyone/operators/builtins/panels/model_evaluation/__init__.py (1)
35-35: Consider using an Enum for evaluation typesUsing a list for supported types is error-prone. An Enum would provide better type safety and maintainability.
Apply this diff to use an Enum:
-SUPPORTED_EVALUATION_TYPES = ["classification", "detection", "segmentation"] +from enum import Enum, auto + +class EvaluationType(str, Enum): + CLASSIFICATION = "classification" + DETECTION = "detection" + SEGMENTATION = "segmentation" + +SUPPORTED_EVALUATION_TYPES = [t.value for t in EvaluationType]app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx (3)
94-101: Extract error handling logic into custom hookThe error state management logic should be extracted into a custom hook for better reusability and separation of concerns.
Create a new hook:
function useEvaluationError(data: any, name: string, compareKey?: string) { const evaluationError = useMemo(() => { return data?.[`evaluation_${name}_error`]; }, [data, name]); const compareEvaluationError = useMemo(() => { return data?.[`evaluation_${compareKey}_error`]; }, [data, compareKey]); return { evaluationError, compareEvaluationError }; }
157-159: Add loading state for error conditionThe error state should show a loading indicator while the error data is being fetched.
Apply this diff:
if (evaluationError) { + if (!data) { + return ( + <Box sx={{ height: "50vh", display: "flex", alignItems: "center", justifyContent: "center" }}> + <CircularProgress /> + </Box> + ); + } return <Error error={evaluationError} onBack={navigateBack} />; }
629-634: Extract common table header stylesThe same table header styles are duplicated in multiple places. Extract them into a styled component.
Create a styled component:
const StyledTableHeader = styled(TableRow)(({ theme }) => ({ 'th p': { color: theme.palette.text.secondary, fontSize: '1rem', fontWeight: 600, }, }));Then use it in place of the duplicated styles.
Also applies to: 902-907, 1085-1090, 1277-1282
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Error.tsx(1 hunks)app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/ErrorIcon.tsx(1 hunks)app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx(19 hunks)fiftyone/operators/builtins/panels/model_evaluation/__init__.py(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/ErrorIcon.tsx
🧰 Additional context used
📓 Path-based instructions (2)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx (1)
Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Error.tsx (1)
Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.
🪛 Biome (1.9.4)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx
[error] 45-45: Do not shadow the global "Error" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Error.tsx
[error] 6-6: Do not shadow the global "Error" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
🔇 Additional comments (2)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Error.tsx (2)
39-42: 🛠️ Refactor suggestion
Add TypeScript type definition for props
The props type should be properly defined using TypeScript for better type safety and documentation.
Add this type definition:
+type ModelEvaluationErrorProps = {
+ onBack: () => void;
+ error: {
+ error: 'unsupported';
+ info: Record<string, unknown>;
+ };
+};
-type ErrorProps = {
- onBack: () => void;
- error: any;
-};Likely invalid or redundant comment.
6-6:
Rename component to avoid shadowing global Error object
The component name shadows the global Error object, which can lead to confusion and potential issues.
Apply this diff to rename the component:
-export default function Error(props) {
+export default function ModelEvaluationError(props) {Likely invalid or redundant comment.
🧰 Tools
🪛 Biome (1.9.4)
[error] 6-6: Do not shadow the global "Error" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
|
|
||
| export default function Error(props) { | ||
| const { onBack, error } = props; | ||
| console.log(">>>", { error }); |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Remove console.log statement
Debug logging should not be present in production code.
Apply this diff to remove the console.log:
- console.log(">>>", { error });| serialized_info = info.serialize() | ||
| evaluation_type = info.config.type | ||
| if evaluation_type not in SUPPORTED_EVALUATION_TYPES: | ||
| ctx.panel.set_data( | ||
| f"evaluation_{computed_eval_key}_error", | ||
| {"error": "unsupported", "info": serialized_info}, | ||
| ) | ||
| return |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Improve error handling in load_evaluation method
The error handling could be more informative by including the actual evaluation type in the error message.
Apply this diff to enhance error feedback:
serialized_info = info.serialize()
evaluation_type = info.config.type
if evaluation_type not in SUPPORTED_EVALUATION_TYPES:
+ supported_types = ", ".join(SUPPORTED_EVALUATION_TYPES)
ctx.panel.set_data(
f"evaluation_{computed_eval_key}_error",
- {"error": "unsupported", "info": serialized_info},
+ {
+ "error": "unsupported",
+ "info": serialized_info,
+ "message": f"Evaluation type '{evaluation_type}' is not supported. Supported types are: {supported_types}"
+ },
)
return📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| serialized_info = info.serialize() | |
| evaluation_type = info.config.type | |
| if evaluation_type not in SUPPORTED_EVALUATION_TYPES: | |
| ctx.panel.set_data( | |
| f"evaluation_{computed_eval_key}_error", | |
| {"error": "unsupported", "info": serialized_info}, | |
| ) | |
| return | |
| serialized_info = info.serialize() | |
| evaluation_type = info.config.type | |
| if evaluation_type not in SUPPORTED_EVALUATION_TYPES: | |
| supported_types = ", ".join(SUPPORTED_EVALUATION_TYPES) | |
| ctx.panel.set_data( | |
| f"evaluation_{computed_eval_key}_error", | |
| { | |
| "error": "unsupported", | |
| "info": serialized_info, | |
| "message": f"Evaluation type '{evaluation_type}' is not supported. Supported types are: {supported_types}" | |
| }, | |
| ) | |
| return |
| hide: isSegmentation, | ||
| }, | ||
| { | ||
| id: "iou", | ||
| property: "IoU Threshold", | ||
| value: evaluationConfig.iou, | ||
| compareValue: compareEvaluationConfig.iou, | ||
| hide: !isObjectDetection, |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Use TypeScript discriminated union for evaluation types
The evaluation type checks should use TypeScript's discriminated unions for better type safety.
Add these types:
type EvaluationType = 'classification' | 'detection' | 'segmentation';
interface BaseEvaluationConfig {
type: EvaluationType;
}
interface ClassificationConfig extends BaseEvaluationConfig {
type: 'classification';
method: 'binary' | 'multiclass';
}
interface DetectionConfig extends BaseEvaluationConfig {
type: 'detection';
iou: number;
}
interface SegmentationConfig extends BaseEvaluationConfig {
type: 'segmentation';
}
type EvaluationConfig = ClassificationConfig | DetectionConfig | SegmentationConfig;
imanjra
force-pushed
the
bugfix/me-panel-tweaks
branch
from
f15a383 to
0142a6e
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx (2)
318-325: Consider extracting metric filtering logicThe metric filtering logic is repeated in multiple places. Consider extracting it into a utility function for better maintainability.
+const filterMetricsByType = (metrics, isSegmentation) => { + return metrics.filter(m => !m.hide); +}; -const computedMetricPerformance = metricPerformance.filter((m) => !m.hide); +const computedMetricPerformance = filterMetricsByType(metricPerformance, isSegmentation);Also applies to: 876-877, 886-887
629-638: Consider extracting table header stylesThe table header styling is duplicated across multiple table components. Consider extracting it into a styled component or theme constant.
+const TableHeaderCell = styled(TableCell)(({ theme }) => ({ + "& p": { + color: theme.palette.text.secondary, + fontSize: "1rem", + fontWeight: 600, + } +})); -<TableCell sx={{ "th p": { /* ... */ } }}> +<TableHeaderCell> <Typography>Metric</Typography> -</TableCell> +</TableHeaderCell>Also applies to: 902-911, 1085-1094, 1277-1286
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Error.tsx(1 hunks)app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/ErrorIcon.tsx(1 hunks)app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx(19 hunks)fiftyone/operators/builtins/panels/model_evaluation/__init__.py(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- fiftyone/operators/builtins/panels/model_evaluation/init.py
- app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/ErrorIcon.tsx
🧰 Additional context used
📓 Path-based instructions (2)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx (1)
Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Error.tsx (1)
Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.
🪛 Biome (1.9.4)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx
[error] 45-45: Do not shadow the global "Error" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Error.tsx
[error] 6-6: Do not shadow the global "Error" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
🔇 Additional comments (5)
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Error.tsx (2)
6-6: Avoid shadowing the global 'Error' object
The component name shadows the global Error object, which can lead to confusion or unexpected behavior.
Also applies to: 38-40
🧰 Tools
🪛 Biome (1.9.4)
[error] 6-6: Do not shadow the global "Error" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
8-35: LGTM! Well-structured error UI
The error component has a clean and user-friendly layout with:
- Clear navigation with a back button
- Centered error icon and messages
- Informative text about supported evaluation types
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx (3)
94-101: LGTM! Well-implemented error state management
Good use of useMemo for deriving error states from the data object, preventing unnecessary recalculations.
157-159: LGTM! Proper error handling flow
Good implementation of early return pattern when evaluation error is detected.
1312-1324: LGTM! Improved table row rendering
Good use of null check to filter out hidden rows before rendering.
What changes are proposed in this pull request?
(Please fill in changes proposed in this fix)
How is this patch tested? If it is not, please explain why.
(Details)
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?
fiftyonePython library changesSummary by CodeRabbit
New Features
Errorcomponent for displaying evaluation errors.ErrorIconcomponent for visual representation of errors.Bug Fixes
Evaluationcomponent to provide user feedback for unsupported evaluation types.Documentation