Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/v1.1.0 to develop #5190

Merged
merged 35 commits into from
Dec 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
0bc217e
treat delegated execution separately
brimoor Nov 23, 2024
5d835ef
leaky splits docs
Nov 25, 2024
46c53ba
fixed name of method
Nov 25, 2024
e345c05
added datasetview as an input option
Nov 25, 2024
40ff57c
fiftyone brain -> the fiftyone brain
Nov 25, 2024
5a823a4
of identifying -> to identify
Nov 25, 2024
d67015a
made language a little more professional
Nov 25, 2024
02d6e70
leakyness -> leakiness
Nov 25, 2024
259e14e
fix
Nov 25, 2024
cdd4a48
Fix deleted datasets on App server (#5183)
benjaminpkane Nov 25, 2024
5834afc
Merge branch 'release/v1.1.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Nov 25, 2024
19ebdad
added more snippets, more thorough explainations
Nov 25, 2024
873287e
compressed image
Nov 25, 2024
cf76f7a
fix confusion matrix in model evaluation panel (#5186)
imanjra Nov 25, 2024
8a72af6
Merge branch 'release/v1.1.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Nov 25, 2024
3a2e112
Updated doc for `panel.img` (#5192)
minhtuev Nov 26, 2024
87bf17c
Merge branch 'release/v1.1.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Nov 26, 2024
241726a
use static execution options where possible
brimoor Nov 26, 2024
ac6799c
Merge pull request #5184 from voxel51/use-ctx-delegate
brimoor Nov 26, 2024
a992ac4
Merge branch 'release/v1.1.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Nov 26, 2024
0900594
typo
Nov 26, 2024
e948e4d
cleaned up example code
Nov 26, 2024
d88e777
bugfix: y-axis autorange reversed on all evaluation chart (#5193)
lanzhenw Nov 26, 2024
a82749d
Merge branch 'release/v1.1.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Nov 26, 2024
0c51930
fix pending evaluation also being listed as completed
imanjra Nov 26, 2024
5e32142
Merge branch 'release/v1.1.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Nov 26, 2024
738b128
Merge pull request #5189 from voxel51/leaky-splits-docs
jacobsela Nov 26, 2024
835ccec
Merge branch 'release/v1.1.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Nov 26, 2024
85e2265
add guards for missing dimensions and location in detection label
sashankaryal Nov 27, 2024
34961bb
Merge pull request #5195 from voxel51/fix/3d-bad-labels
sashankaryal Nov 27, 2024
3ae877c
Merge branch 'release/v1.1.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Nov 27, 2024
9f690fe
Updated from Slack to Discord (#5196)
minhtuev Nov 27, 2024
4867bd5
Merge branch 'release/v1.1.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Nov 27, 2024
7287351
make icon in panel table have circle background on hover (#5197)
CamronStaley Nov 27, 2024
a16fb12
Merge branch 'release/v1.1.0' of https://github.com/voxel51/fiftyone …
voxel51-bot Nov 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/packages/app/src/components/Nav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {
GitHubLink,
Header,
IconButton,
SlackLink,
DiscordLink,
iconContainer,
} from "@fiftyone/components";
import { ViewBar } from "@fiftyone/core";
Expand Down Expand Up @@ -111,7 +111,7 @@ const Nav: React.FC<
>
{mode === "dark" ? <LightMode color="inherit" /> : <DarkMode />}
</IconButton>
<SlackLink />
<DiscordLink />
<GitHubLink />
<DocsLink />
</div>
Expand Down
4 changes: 2 additions & 2 deletions app/packages/app/src/components/Setup.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {
DocsLink,
GitHubLink,
Header,
SlackLink,
DiscordLink,
iconContainer,
useTheme,
} from "@fiftyone/components";
Expand Down Expand Up @@ -190,7 +190,7 @@ const Setup = () => {
<div data-cy="setup-page">
<Header title={"FiftyOne"}>
<div className={iconContainer} style={{ flex: 1 }}>
<SlackLink />
<DiscordLink />
<GitHubLink />
<DocsLink />
</div>
Expand Down
9 changes: 5 additions & 4 deletions app/packages/components/src/components/Icons/Icons.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,19 @@ import { iconLink } from "./Icons.module.css";

export { iconContainer } from "./Icons.module.css";

export const SlackLink = () => (
export const DiscordLink = () => (
<ExternalLink
className={iconLink}
href={"https://slack.voxel51.com"}
title={"Slack"}
href={"https://community.voxel51.com/"}
title={"Discord"}
>
<SvgIcon
sx={{
fill: (theme) => theme.palette.text.secondary,
}}
viewBox="0 0 127.14 96.36"
>
<path d="M6 15a2 2 0 0 1-2 2a2 2 0 0 1-2-2a2 2 0 0 1 2-2h2v2m1 0a2 2 0 0 1 2-2a2 2 0 0 1 2 2v5a2 2 0 0 1-2 2a2 2 0 0 1-2-2v-5m2-8a2 2 0 0 1-2-2a2 2 0 0 1 2-2a2 2 0 0 1 2 2v2H9m0 1a2 2 0 0 1 2 2a2 2 0 0 1-2 2H4a2 2 0 0 1-2-2a2 2 0 0 1 2-2h5m8 2a2 2 0 0 1 2-2a2 2 0 0 1 2 2a2 2 0 0 1-2 2h-2v-2m-1 0a2 2 0 0 1-2 2a2 2 0 0 1-2-2V5a2 2 0 0 1 2-2a2 2 0 0 1 2 2v5m-2 8a2 2 0 0 1 2 2a2 2 0 0 1-2 2a2 2 0 0 1-2-2v-2h2m0-1a2 2 0 0 1-2-2a2 2 0 0 1 2-2h5a2 2 0 0 1 2 2a2 2 0 0 1-2 2h-5z" />
<path d="M107.7,8.07A105.15,105.15,0,0,0,81.47,0a72.06,72.06,0,0,0-3.36,6.83A97.68,97.68,0,0,0,49,6.83,72.37,72.37,0,0,0,45.64,0,105.89,105.89,0,0,0,19.39,8.09C2.79,32.65-1.71,56.6.54,80.21h0A105.73,105.73,0,0,0,32.71,96.36,77.7,77.7,0,0,0,39.6,85.25a68.42,68.42,0,0,1-10.85-5.18c.91-.66,1.8-1.34,2.66-2a75.57,75.57,0,0,0,64.32,0c.87.71,1.76,1.39,2.66,2a68.68,68.68,0,0,1-10.87,5.19,77,77,0,0,0,6.89,11.1A105.25,105.25,0,0,0,126.6,80.22h0C129.24,52.84,122.09,29.11,107.7,8.07ZM42.45,65.69C36.18,65.69,31,60,31,53s5-12.74,11.43-12.74S54,46,53.89,53,48.84,65.69,42.45,65.69Zm42.24,0C78.41,65.69,73.25,60,73.25,53s5-12.74,11.44-12.74S96.23,46,96.12,53,91.08,65.69,84.69,65.69Z" />
</SvgIcon>
</ExternalLink>
);
Expand Down
2 changes: 1 addition & 1 deletion app/packages/components/src/components/Icons/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ export {
KeyboardArrowUp,
LookerArrowLeftIcon,
LookerArrowRightIcon,
SlackLink,
DiscordLink,
} from "./Icons";
44 changes: 30 additions & 14 deletions app/packages/core/src/plugins/SchemaIO/components/ActionsMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,13 @@ function Action(props: ActionPropsType) {
const { label, name, onClick, icon, variant, mode, color, size, tooltip } =
props;
const resolvedColor = color ? getColorByCode(color) : undefined;

const Icon = icon ? (
<MuiIconFont name={icon} sx={{ color: resolvedColor }} />
<MuiIconFont
name={icon}
sx={{
color: resolvedColor,
}}
/>
) : null;

const handleClick = useCallback(
Expand All @@ -91,18 +95,30 @@ function Action(props: ActionPropsType) {

const content =
mode === "inline" ? (
<Button
variant={variant}
startIcon={Icon}
onClick={handleClick}
sx={{
color: resolvedColor,
padding: size === "small" ? 0 : undefined,
minWidth: size === "small" ? 40 : undefined,
}}
>
{label}
</Button>
label ? (
<Button
variant={variant}
startIcon={Icon}
onClick={handleClick}
sx={{
color: resolvedColor,
padding: size === "small" ? 0 : undefined,
minWidth: size === "small" ? 40 : undefined,
}}
>
{label}
</Button>
) : (
<IconButton
onClick={handleClick}
size={size}
sx={{
color: resolvedColor,
}}
>
{Icon}
</IconButton>
)
) : (
<MenuItem onClick={handleClick}>
{Icon && <ListItemIcon>{Icon}</ListItemIcon>}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1155,12 +1155,28 @@ export default function Evaluation(props: EvaluationProps) {
colorscale: confusionMatrixConfig.log
? confusionMatrix?.colorscale || "viridis"
: "viridis",
hovertemplate:
[
"<b>count: %{z:d}</b>",
`${
evaluation?.info?.config?.gt_field || "truth"
}: %{y}`,
`${
evaluation?.info?.config?.pred_field ||
"predicted"
}: %{x}`,
].join(" <br>") + "<extra></extra>",
},
]}
onClick={({ points }) => {
const firstPoint = points[0];
loadView("matrix", { x: firstPoint.x, y: firstPoint.y });
}}
layout={{
yaxis: {
autorange: "reversed",
},
}}
/>
</Stack>
{compareKey && (
Expand All @@ -1183,8 +1199,24 @@ export default function Evaluation(props: EvaluationProps) {
colorscale: confusionMatrixConfig.log
? compareConfusionMatrix?.colorscale || "viridis"
: "viridis",
hovertemplate:
[
"<b>count: %{z:d}</b>",
`${
evaluation?.info?.config?.gt_field || "truth"
}: %{y}`,
`${
evaluation?.info?.config?.pred_field ||
"predicted"
}: %{x}`,
].join(" <br>") + "<extra></extra>",
},
]}
layout={{
yaxis: {
autorange: "reversed",
},
}}
/>
</Stack>
)}
Expand Down Expand Up @@ -1532,8 +1564,8 @@ function getMatrix(matrices, config) {
if (!matrices) return;
const { sortBy = "az", limit } = config;
const parsedLimit = typeof limit === "number" ? limit : undefined;
const classes = matrices[`${sortBy}_classes`].slice(parsedLimit);
const matrix = matrices[`${sortBy}_matrix`].slice(parsedLimit);
const classes = matrices[`${sortBy}_classes`].slice(0, parsedLimit);
const matrix = matrices[`${sortBy}_matrix`].slice(0, parsedLimit);
const colorscale = matrices[`${sortBy}_colorscale`];
return { labels: classes, matrix, colorscale };
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { useTheme } from "@fiftyone/components";
import { merge } from "lodash";
import React, { useMemo } from "react";
import Plot, { PlotParams } from "react-plotly.js";

Expand Down Expand Up @@ -31,7 +32,6 @@ export default function EvaluationPlot(props: EvaluationPlotProps) {
color: theme.text.secondary,
gridcolor: theme.primary.softBorder,
automargin: true, // Enable automatic margin adjustment
scaleanchor: "x",
},
autosize: true,
margin: { t: 20, l: 50, b: 50, r: 20, pad: 0 },
Expand All @@ -45,6 +45,11 @@ export default function EvaluationPlot(props: EvaluationPlotProps) {
},
};
}, [theme]);

const mergedLayout = useMemo(() => {
return merge({}, layoutDefaults, layout);
}, [layoutDefaults, layout]);

const configDefaults: PlotConfig = useMemo(() => {
return {
displaylogo: false,
Expand All @@ -66,7 +71,7 @@ export default function EvaluationPlot(props: EvaluationPlotProps) {
return (
<Plot
config={configDefaults}
layout={{ ...layoutDefaults, ...layout }}
layout={mergedLayout}
style={{ height: "100%", width: "100%", zIndex: 1, ...style }}
data={data}
{...otherProps}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -222,12 +222,14 @@ export default function TableView(props: ViewPropsType) {
: "unset",
}}
>
{currentRowHasActions && (
{currentRowHasActions ? (
<ActionsMenu
actions={getRowActions(rowIndex)}
size={size}
maxInline={max_inline_actions}
/>
) : (
<Box sx={{ minHeight: "32px" }} />
)}
</TableCell>
)}
Expand Down
6 changes: 5 additions & 1 deletion app/packages/looker-3d/src/labels/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,11 @@ export const ThreeDLabels = ({ sampleMap }: ThreeDLabelsProps) => {
const newPolylineOverlays = [];

for (const overlay of rawOverlays) {
if (overlay._cls === "Detection") {
if (
overlay._cls === "Detection" &&
overlay.dimensions &&
overlay.location
) {
newCuboidOverlays.push(
<Cuboid
key={`cuboid-${overlay.id ?? overlay._id}-${overlay.sampleId}`}
Expand Down
2 changes: 1 addition & 1 deletion app/packages/looker/src/overlays/detection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export default class DetectionOverlay<
this.label.mask && this.drawMask(ctx, state);
!state.config.thumbnail && this.drawLabelText(ctx, state);

if (this.is3D) {
if (this.is3D && this.label.dimensions && this.label.location) {
this.fillRectFor3d(ctx, state, this.getColor(state));
} else {
this.strokeRect(ctx, state, this.getColor(state));
Expand Down
6 changes: 5 additions & 1 deletion app/packages/looker/src/worker/threed-label-processor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ const getInferredParamsForUndefinedProjection = (

if (cls === DETECTIONS) {
for (const detection of label.detections as DetectionLabel[]) {
if (!detection.location || !detection.dimensions) {
continue;
}

const [x, y] = detection.location;
const [lx, ly] = detection.dimensions;

Expand All @@ -55,7 +59,7 @@ const getInferredParamsForUndefinedProjection = (
minY = Math.min(minY, y - ly / 2);
maxY = Math.max(maxY, y + ly / 2);
}
} else if (cls === "Detection") {
} else if (cls === "Detection" && label.location && label.dimensions) {
const [x, y] = label.location as DetectionLabel["location"];
const [lx, ly] = label.dimensions as DetectionLabel["dimensions"];

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions docs/source/_templates/layout.html
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
<div class="nav__item nav__dropdown__menu has-arrows">
<div class="arrow-up--light-primary arrow-left20"></div>
<ul>
<li><a href="{{link_voxel51_slack}}">Community Slack</a></li>
<li><a href="{{link_voxel51_discord}}">Community Discord</a></li>
<li><a href="{{link_voxel51_blog}}">Blog</a></li>
<li><a href="{{link_events}}">Events</a></li>
</ul>
Expand Down Expand Up @@ -140,7 +140,7 @@
<a href="{{link_voxel51_blog}}">Blog</a>
<a href="{{link_docs_fiftyone}}">Docs</a>
<a href="{{link_voxel51_github}}">GitHub</a>
<a href="{{link_voxel51_slack}}">Slack</a>
<a href="{{link_voxel51_discord}}">Discord</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Additional updates needed for complete Slack to Discord migration

While the footer link has been updated to Discord, there are still remaining Slack references in other files that need to be addressed:

  • docs/source/conf.py: Contains an unused Slack link variable
  • docs/source/release-notes.rst: Contains a reference to an expired Slack link

Please update these remaining references to maintain consistency with the Discord migration.

🔗 Analysis chain

LGTM: Footer Discord link update

Clean replacement of Slack with Discord in the footer links section.

Let's verify the Discord link configuration:


Let me analyze the output to verify the Discord link configuration.


Let me check the content of the remaining files that contain Slack references.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify Discord link configuration in conf.py and its usage

# Check if link_voxel51_discord is defined in conf.py
rg "link_voxel51_discord" docs/source/conf.py

# Check for any remaining Slack references that might need updating
rg -i "slack" docs/source/

Length of output: 131388


Script:

#!/bin/bash
# Check for any remaining Slack references in the layout template
rg "slack" docs/source/_templates/layout.html

# Check for any remaining Slack references in other files that might need updating
rg -l "slack" docs/source/

Length of output: 122


Script:

#!/bin/bash
# Check the content of conf.py and release-notes.rst for Slack references
rg -A 2 -B 2 "slack" docs/source/conf.py docs/source/release-notes.rst

Length of output: 728

<a href="{{link_ourstory}}">About Us</a>
<a href="{{link_events}}">Events</a>
<a href="{{link_voxel51_jobs}}">Careers</a>
Expand Down
Loading
Loading