-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(workflows): replace secrets.TEAMS_GITHUB_PAT
with fine grained org secret RO_FOT_FG_PAT
.
#5173
Conversation
…ined org secret `RO_FOT_FG_PAT`.
WalkthroughThe pull request modifies the GitHub Actions workflow configuration in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
.github/workflows/build-docs.yml (2)
Line range hint
40-40
: Fix invalid GitHub runner specificationThe
ubuntu-latest-m
is not a valid GitHub-hosted runner. This should be changed to a valid option.Apply this diff to fix the runner:
- runs-on: ubuntu-latest-m + runs-on: ubuntu-latest
Line range hint
108-108
: Consider updating to a newer Ubuntu versionThe job is using
ubuntu-20.04
which, while still supported, has an end-of-life approaching. Consider updating toubuntu-latest
or a newer LTS version for longer-term maintainability.Apply this diff to update the runner:
- runs-on: ubuntu-20.04 + runs-on: ubuntu-latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to know, thanks. yep its read only - it links in some of the Teams-specific folders so that autodoc of API includes those modules (e.g., fiftyone.management)
What changes are proposed in this pull request?
Aloha is improving our use of Personal Access Tokens by moving them towards GitHub Organization secrets. These will be easier to manage (and update) when they expire).
The only reference of
TEAMS_GITHUB_PAT
is in.github/workflows/build-docs.yml
. This workflow appears to only need read access tovoxel51/fiftyone-teams
, so use a fine grained PAT with only that permission.How is this patch tested? If it is not, please explain why.
Will be tested in the action run https://github.com/voxel51/fiftyone/actions/runs/11960057931/job/33343225189
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?
fiftyone
Python library changesSummary by CodeRabbit