Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plugin components #4927
Update plugin components #4927
Changes from 42 commits
741ace3
5d45615
8a36c84
5bea4b7
71bd61a
ab131b3
b589949
9c1a519
9b02e46
162f883
4827e44
da99e2d
930acd6
2f1bf5e
e56ecc2
c3c70dc
d24a5ac
aacf655
62de88e
e3448f1
6404f05
81fe8f8
fa57350
f377f13
5894643
ca1bccd
7771d0a
d1f0541
0c8a8a6
3fd5ba8
ea56505
b095575
66daf79
d1260b7
af9f0f7
947731c
cb7dfec
4972cbc
3d67489
6f81d66
dfb8681
c2c3fcc
a9fde0a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enhance type safety in
ModalButtonView
interface.The
componentsProps
property is typed asany
, which reduces type safety. Consider defining a more specific type structure.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider using a single state object for text alignment configuration.
The current implementation uses multiple variables for alignment. Consider consolidating them into a single state object for better maintainability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Make modal styles more configurable through props.
The modal styles are currently hardcoded. Consider making them configurable through props to support different use cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Use enum for functionality type instead of string comparison.
Using string comparison for functionality type is error-prone. Consider using an enum instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Extract icon rendering into a separate component.
The icon rendering logic could be extracted into a reusable component for better maintainability and reusability.
📝 Committable suggestion