Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce modal action row button size for better fit #4814

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

imanjra
Copy link
Contributor

@imanjra imanjra commented Sep 18, 2024

What changes are proposed in this pull request?

reduce modal action row button size for better fit

How is this patch tested? If it is not, please explain why.

Using modal in normal and fullscreen mode:

image
image

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Summary by CodeRabbit

  • New Features

    • Enhanced visual layout of the modal actions with improved styling for SVG icons and nested elements.
  • Style

    • Introduced new CSS styles for consistent sizing and appearance of icons and div elements in the modal actions.

@imanjra imanjra requested review from sashankaryal and a team September 18, 2024 04:51
Copy link
Contributor

coderabbitai bot commented Sep 18, 2024

Walkthrough

The changes involve updating the ActionsRow.tsx file by adding new CSS styles to the ModalActionsRowContainer styled component. These updates specifically target the styling of svg elements and child div elements, ensuring consistent sizing and layout within the user interface.

Changes

File Path Change Summary
app/packages/core/src/components/Actions/... Added CSS styles for svg elements (font size 18px) and child div elements (max height 24px).

Poem

In a row where actions play,
SVGs shine bright, come what may.
With styles refined, they stand so tall,
A tidy space, pleasing to all!
Hooray for changes, let’s hop and cheer,
For a smoother UI, let’s spread the cheer! 🐇✨


Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d4697f7 and 43b6a21.

Files selected for processing (1)
  • app/packages/core/src/components/Actions/ActionsRow.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • app/packages/core/src/components/Actions/ActionsRow.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@sashankaryal sashankaryal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@imanjra imanjra force-pushed the bugfix/modal-actions-row-size branch from d4697f7 to 43b6a21 Compare September 24, 2024 20:30
@imanjra imanjra merged commit 8a17804 into develop Sep 24, 2024
11 checks passed
@imanjra imanjra deleted the bugfix/modal-actions-row-size branch September 24, 2024 22:13
@coderabbitai coderabbitai bot mentioned this pull request Oct 24, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants