-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect against infinitely growing content size batcher #4806
Conversation
WalkthroughThe changes involve modifications to the Changes
Poem
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (2)
Additional comments not posted (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
What changes are proposed in this pull request?
If content size batcher is not getting backpressure properly, it would just keep increasing batch size to infinity. Eventually causing problems.
If some versions were misaligned, this was possible to rear its ugly head in Teams.
Let's just cap the batcher (via
max_batch_size
) totarget_size
, which would mean 1 byte per object.How is this patch tested? If it is not, please explain why.
This is essentially what was happening (fixed backpressure) so let's just prevent it.
Before 👎🏼
After 👍🏼
Summary by CodeRabbit
New Features
max_batch_size
parameter, improving memory efficiency.Bug Fixes
Documentation