Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Teams Link #4127

Merged
merged 6 commits into from
Mar 8, 2024
Merged

Update Teams Link #4127

merged 6 commits into from
Mar 8, 2024

Conversation

benjaminpkane
Copy link
Contributor

What changes are proposed in this pull request?

Removes the built-in Teams form in favor of a simple link to https://voxel51.com/book-a-demo/

Screen.Recording.2024-03-05.at.3.12.42.PM.mov

How is this patch tested? If it is not, please explain why.

Locally

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@benjaminpkane benjaminpkane requested review from ritch and brimoor March 5, 2024 21:13
@benjaminpkane benjaminpkane self-assigned this Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/v0.23.7@cf23db0). Click here to learn what that means.

Files Patch % Lines
app/packages/app/src/components/Nav.tsx 0.00% 31 Missing ⚠️
app/packages/app/src/components/Teams.tsx 0.00% 12 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v0.23.7    #4127   +/-   ##
==================================================
  Coverage                   ?   16.03%           
==================================================
  Files                      ?      733           
  Lines                      ?    82012           
  Branches                   ?     1118           
==================================================
  Hits                       ?    13153           
  Misses                     ?    68859           
  Partials                   ?        0           
Flag Coverage Δ
app 16.03% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminpkane benjaminpkane changed the base branch from release/v0.23.6 to merge/v0.23.6-to-main March 5, 2024 21:40
brimoor
brimoor previously approved these changes Mar 6, 2024
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clicked the button, tested both light and dark theme 🥇

@benjaminpkane benjaminpkane marked this pull request as draft March 6, 2024 14:55
@benjaminpkane benjaminpkane changed the title Update Teams Link [HOLD] Update Teams Link Mar 6, 2024
Base automatically changed from merge/v0.23.6-to-main to main March 6, 2024 20:06
@benjaminpkane benjaminpkane changed the base branch from main to release/v0.23.7 March 6, 2024 20:57
@benjaminpkane benjaminpkane dismissed brimoor’s stale review March 6, 2024 20:57

The base branch was changed.

@benjaminpkane benjaminpkane marked this pull request as ready for review March 6, 2024 20:57
@benjaminpkane benjaminpkane changed the title [HOLD] Update Teams Link Update Teams Link Mar 6, 2024
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminpkane benjaminpkane merged commit fc22e8b into release/v0.23.7 Mar 8, 2024
15 checks passed
@benjaminpkane benjaminpkane deleted the bug/teams-form branch March 8, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants