-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix on_startup operator not executing on startup #4125
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import { useEffect } from "react"; | ||
import { executeStartupOperators } from "./operators"; | ||
|
||
let startupOperatorsExecuted = false; | ||
|
||
export default function StartupOperatorExecutor() { | ||
useEffect(() => { | ||
if (!startupOperatorsExecuted) { | ||
executeStartupOperators(); | ||
startupOperatorsExecuted = true; | ||
} | ||
}, []); | ||
|
||
return null; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,26 +4,19 @@ import { useEffect, useState } from "react"; | |
import { useRecoilValue, useSetRecoilState } from "recoil"; | ||
import { registerBuiltInOperators } from "./built-in-operators"; | ||
import { useOperatorPlacementsResolver } from "./hooks"; | ||
import { executeStartupOperators, loadOperatorsFromServer } from "./operators"; | ||
import { loadOperatorsFromServer } from "./operators"; | ||
import { | ||
availableOperatorsRefreshCount, | ||
operatorsInitializedAtom, | ||
} from "./state"; | ||
|
||
let startupOperatorsExecuted = false; | ||
|
||
async function loadOperators(datasetName: string) { | ||
registerBuiltInOperators(); | ||
await loadOperatorsFromServer(datasetName); | ||
if (!startupOperatorsExecuted) { | ||
executeStartupOperators(); | ||
startupOperatorsExecuted = true; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe the doc string below is incorrect now? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yah, good point. I will update the doc string below. |
||
} | ||
|
||
/** | ||
* Load built-in and installed JavaScript and Python operators and queue all | ||
* start-up operators for execution. | ||
* Load built-in and installed JavaScript and Python operators and initialize | ||
*/ | ||
export function useOperators(datasetLess?: boolean) { | ||
const [ready, setReady] = useState(false); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a workaround to the actual problem. How can we make the following possible regardless of where or when it happens:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its important that
executeOperator()
is essentially possible from any state, thats why we introduced the queue in the first place.