Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use loadable for ctx.current_sample #3814

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Conversation

benjaminpkane
Copy link
Contributor

Follow up to #3792. A small detail specifically for group datasets is that the recoil value may suspend for a PCD slice, as the value depends on a server query. Revealed by and fixes e2e

@benjaminpkane benjaminpkane added bug Bug fixes app Issues related to App features labels Nov 16, 2023
@benjaminpkane benjaminpkane self-assigned this Nov 16, 2023
@benjaminpkane benjaminpkane changed the title Use loadable ctx.current_sample Use loadable for ctx.current_sample Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 1657 lines in your changes are missing coverage. Please review.

Comparison is base (e0e6505) 15.57% compared to head (deddaa1) 15.40%.
Report is 22 commits behind head on develop.

Files Patch % Lines
...rc/components/ColorModal/controls/IdxColorList.tsx 0.00% 262 Missing ⚠️
app/packages/core/src/components/Starter/index.tsx 0.00% 243 Missing ⚠️
...nents/ColorModal/colorPalette/FieldsMaskTarget.tsx 0.00% 95 Missing ⚠️
...nts/ColorModal/colorPalette/DefaultMaskTargets.tsx 0.00% 92 Missing ⚠️
.../src/plugins/SchemaIO/components/LazyFieldView.tsx 0.00% 92 Missing ⚠️
...es/core/src/components/ColorModal/FieldSetting.tsx 0.00% 83 Missing ⚠️
app/packages/core/src/components/Common/Input.tsx 0.00% 83 Missing ⚠️
app/packages/operators/src/hooks.ts 0.00% 80 Missing ⚠️
...pp/packages/core/src/components/Starter/content.ts 0.00% 75 Missing ⚠️
app/packages/operators/src/state.ts 0.00% 70 Missing ⚠️
... and 32 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3814      +/-   ##
===========================================
- Coverage    15.57%   15.40%   -0.17%     
===========================================
  Files          645      657      +12     
  Lines        74120    75570    +1450     
  Branches       990     1000      +10     
===========================================
+ Hits         11542    11644     +102     
- Misses       62578    63926    +1348     
Flag Coverage Δ
app 15.40% <6.01%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@imanjra imanjra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminpkane benjaminpkane merged commit 1d07603 into develop Nov 17, 2023
@benjaminpkane benjaminpkane deleted the bug/current-sample-loadable branch November 17, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Issues related to App features bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants