-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App supports bazel #3338
App supports bazel #3338
Conversation
Only use MPS when manually specified
Allow FiftyOne App execution under bazel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @mys007!
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #3338 +/- ##
========================================
Coverage 15.48% 15.48%
========================================
Files 569 569
Lines 70351 70351
Branches 687 687
========================================
Hits 10895 10895
Misses 59456 59456
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What changes are proposed in this pull request?
When fiftyone is installed under bazel environment and
fo.launch_app()
is called, the App does not launch and only 404 is displayed.This is because bazel creates virtual package installations, where everything - including
fiftyone/server/static
- is just a symbolic link to a central, shared location. The story with bazel is also mentioned in encode/starlette#1083 and was one of the motivation for introducingStaticFiles(follow_symlink=True)
for this purpose.This PR turns on the support for symlinks for the
static
directory, so that fiftyone works with bazel.How is this patch tested? If it is not, please explain why.
Tested locally.
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?
fiftyone
Python library changes