eslint updates

voxel51 · Jul 8, 2024 · a9a9db2 · a9a9db2
1 parent d9ff080
commit a9a9db2
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 11 deletions.
diff --git a/e2e-pw/package.json b/e2e-pw/package.json
@@ -22,7 +22,7 @@
         "wait-on": "^7.2.0"
     },
     "scripts": {
-        "lint": "bash -c 'set +e; eslint; set -e; tsc --skipLibCheck --noImplicitAny --sourceMap false'",
+        "lint": "bash -c 'set +e; eslint ./src; set -e; tsc --skipLibCheck --noImplicitAny --sourceMap false'",
         "unittests": "vitest",
         "check-flaky": "./scripts/check-flaky.sh",
         "kill-port": "./scripts/kill-port.sh",

diff --git a/e2e-pw/src/oss/poms/grid/index.ts b/e2e-pw/src/oss/poms/grid/index.ts
@@ -95,8 +95,7 @@ class GridAsserter {
 
   async isNthSampleSelected(n: number) {
     const checkbox = await this.gridPom.getNthCheckbox(n);
-    const isChecked = await checkbox.isChecked();
-    expect(isChecked).toBe(true);
+    await expect(checkbox).toBeChecked();
   }
 
   async nthSampleHasTagValue(
@@ -120,9 +119,7 @@ class GridAsserter {
       return;
     }
 
-    const count = await action.first().textContent();
-
-    expect(count).toBe(String(n));
+    await expect(action.first()).toHaveText(String(n));
   }
 
   async isEntryCountTextEqualTo(text: string) {

diff --git a/e2e-pw/src/oss/poms/modal/index.ts b/e2e-pw/src/oss/poms/modal/index.ts
@@ -243,9 +243,7 @@ class ModalAsserter {
   async verifySelectionCount(n: number) {
     const action = this.modalPom.locator.getByTestId("action-manage-selected");
 
-    const count = await action.first().textContent();
-
-    expect(count).toBe(String(n));
+    await expect(action.first()).toHaveText(String(n));
   }
 
   async verifyCarouselLength(expectedCount: number) {

diff --git a/e2e-pw/src/oss/poms/operators/operators-prompt.ts b/e2e-pw/src/oss/poms/operators/operators-prompt.ts
@@ -57,7 +57,7 @@ class OperatorsPromptAsserter {
     await expect(this.panelPom.locator).toBeVisible();
   }
   async isClosed() {
-    await expect(this.panelPom.locator).not.toBeVisible();
+    await expect(this.panelPom.locator).toBeHidden();
   }
   async isExecuting() {
     await expect(this.panelPom.locator).toContainText("Executing...");

diff --git a/e2e-pw/src/shared/media-factory/video.ts b/e2e-pw/src/shared/media-factory/video.ts
@@ -38,7 +38,7 @@ export const createBlankVideo = async (
     frameRate
   )} -c:v libvpx -b:v 1M -pix_fmt yuv420p ${outputPath}`;
 
-  const proc = spawnSync(ffmpegCommand, {
+  spawnSync(ffmpegCommand, {
     shell: true,
     timeout: Duration.Seconds(5),
   });