Lightning filter fixes (#4757)

* minor lightning fixes

* add test

* add note

app/packages/core/src/components/Filters/StringFilter/Checkboxes.tsx

@@ -180,7 +180,8 @@ const Checkboxes = ({
   const show = useRecoilValue(showSearchSelector({ modal, path }));
   const getCount = useGetCount(modal, path);
 
-  if (loading) {
+  // if results are null, and show is false, values are loading
+  if (loading || (!show && results === null)) {
     return <LoadingDots text={"Loading"} />;
   }
 

app/packages/core/src/components/Filters/StringFilter/useSelected.ts

@@ -57,6 +57,7 @@ export default function (
   const shown =
     (resultsLoadable.state !== "loading" || lightning) &&
     (showSearch || length > CHECKBOX_LIMIT);
+
   return {
     results,
     useSearch: useRecoilValue(hasSearchResultsSelector(path))

app/packages/core/src/components/Sidebar/Entries/FilterablePathEntry/FilterItem.tsx

@@ -23,7 +23,7 @@ export const FILTERS = {
   [fou.INT_FIELD]: filters.NumericFieldFilter,
   [fou.OBJECT_ID_FIELD]: filters.StringFieldFilter,
   [fou.STRING_FIELD]: filters.StringFieldFilter,
-  ["_LABEL_TAGS"]: filters.LabelFieldFilter,
+  _LABEL_TAGS: filters.LabelFieldFilter,
 };
 
 const FilterItem = ({

app/packages/state/src/recoil/lightning.test.ts

@@ -0,0 +1,25 @@
+import { describe, expect, it, vi } from "vitest";
+
+vi.mock("recoil");
+vi.mock("recoil-relay");
+
+import { TestSelectorFamily, setMockAtoms } from "../../../../__mocks__/recoil";
+import * as lightning from "./lightning";
+
+describe("tests lightning selectors", () => {
+  it("resolves wildcard indexed fields with database path", () => {
+    const test = <TestSelectorFamily<typeof lightning.lightningPaths>>(
+      (<unknown>lightning.lightningPaths("ground_truth"))
+    );
+    setMockAtoms({
+      dbPath: (p) =>
+        p === "ground_truth.id" ? "ground_truth._id" : "ground_truth.label",
+      expandPath: () => "ground_truth",
+      fieldPaths: () => ["id", "label"],
+      indexesByPath: new Set(["ground_truth._id", "ground_truth.label"]),
+      isLabelPath: () => true,
+    });
+
+    expect(test()).toEqual(new Set(["ground_truth.id", "ground_truth.label"]));
+  });
+});

app/packages/state/src/recoil/lightning.ts

@@ -169,7 +169,7 @@ export const lightningPaths = selectorFamily<Set<string>, string>({
             })
           )
             .map((p) => `${expanded}.${p}`)
-            .filter((p) => indexes.has(p))
+            .filter((p) => indexes.has(get(schemaAtoms.dbPath(p))))
         );
       }