fix modal not rendering properly in qp mode (#5076)

voxel51 · Nov 8, 2024 · 3ae950e · 3ae950e
1 parent c2d05fb
commit 3ae950e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/app/packages/core/src/components/Filters/NumericFieldFilter/NumericFieldFilter.tsx b/app/packages/core/src/components/Filters/NumericFieldFilter/NumericFieldFilter.tsx
@@ -61,7 +61,7 @@ const NumericFieldFilter = ({ color, modal, named = true, path }: Props) => {
     setShowRange(true);
   };
 
-  const showButton = isGroup && queryPerformance && !showRange;
+  const showButton = isGroup && queryPerformance && !showRange && !modal;
 
   return (
     <Container onClick={(e) => e.stopPropagation()}>

diff --git a/app/packages/core/src/components/Filters/StringFilter/Checkboxes.tsx b/app/packages/core/src/components/Filters/StringFilter/Checkboxes.tsx
@@ -105,7 +105,9 @@ const useValues = ({
   const boolean = useRecoilValue(isBooleanField(path));
 
   const hasCheckboxResults =
-    (!queryPerformance && counts.size <= CHECKBOX_LIMIT && !objectId) ||
+    ((!queryPerformance || modal) &&
+      counts.size <= CHECKBOX_LIMIT &&
+      !objectId) ||
     skeleton ||
     boolean;
 

diff --git a/app/packages/state/src/recoil/pathFilters/numeric.ts b/app/packages/state/src/recoil/pathFilters/numeric.ts
@@ -6,7 +6,7 @@ import * as filterAtoms from "../filters";
 import * as pathData from "../pathData";
 import type { Range } from "../utils";
 import { isFilterDefault } from "./utils";
-import { pathHasIndexes, queryPerformance } from "../queryPerformance";
+import { queryPerformance } from "../queryPerformance";
 
 export interface NumericFilter {
   range: Range;
@@ -147,7 +147,7 @@ export const boundsAtom = selectorFamily<
   get:
     (params) =>
     ({ get }) => {
-      if (get(queryPerformance)) {
+      if (get(queryPerformance) && !params.modal) {
         return get(pathData.lightningBounds(params.path));
       }