Merge branch 'release/v1.0.0' of https://github.com/voxel51/fiftyone …

…into develop
voxel51 · Sep 27, 2024 · 1e05d11 · 1e05d11
2 parents cb040ed + b305252
commit 1e05d11
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/packages/analytics/src/analytics.test.ts b/app/packages/analytics/src/analytics.test.ts
@@ -151,7 +151,7 @@ describe("Analytics", () => {
     // segment should be called with context.page.url = undefined
     expect(mockSegment.track).toHaveBeenCalledWith("custom_event", undefined, {
       context: {
-        page: { url: undefined },
+        page: { url: null, path: null, title: null },
       },
     });
   });
@@ -208,7 +208,7 @@ describe("Analytics", () => {
       version: "1.0.0",
     });
   });
-  
+
   describe("analytics.page()", () => {
     it("should call segment.page()", () => {
       analytics = new Analytics();

diff --git a/app/packages/analytics/src/usingAnalytics.ts b/app/packages/analytics/src/usingAnalytics.ts
@@ -123,7 +123,7 @@ export class Analytics {
     if (!this._segment) return;
     let opts;
     if (this._disableUrlTracking) {
-      opts = { context: { page: { url: undefined } } };
+      opts = { context: { page: { url: null, path: null, title: null } } };
     }
     if (this._version) {
       opts = { ...opts, version: this._version };