fix dataset group slice is not being used on launch_app #4527
pr.yml
on: pull_request
Matrix: test / test-python
build
/
changes
23s
build
/
build
2m 18s
test
/
test-app
1m 6s
e2e
/
test-e2e
18m 31s
all-tests
0s
Annotations
10 errors, 18 warnings, and 1 notice
[chromium] › oss/specs/groups/sparse-groups-scenes.spec.ts:56:1 › ego default group slice transitions:
e2e-pw/src/oss/poms/grid/index.ts#L118
1) [chromium] › oss/specs/groups/sparse-groups-scenes.spec.ts:56:1 › ego default group slice transitions
TimeoutError: page.waitForFunction: Timeout 2000ms exceeded.
at oss/poms/grid/index.ts:118
116 |
117 | async isEntryCountTextEqualTo(text: string) {
> 118 | return this.gridPom.page.waitForFunction(
| ^
119 | (text_) => {
120 | return (
121 | document.querySelector("[data-cy='entry-counts']").textContent ===
at GridAsserter.isEntryCountTextEqualTo (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/grid/index.ts:118:30)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/groups/sparse-groups-scenes.spec.ts:57:21
|
[chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › mp4 second slice:
e2e-pw/src/oss/poms/grid/index.ts#L118
2) [chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › mp4 second slice ───────────────────
TimeoutError: page.waitForFunction: Timeout 2000ms exceeded.
at oss/poms/grid/index.ts:118
116 |
117 | async isEntryCountTextEqualTo(text: string) {
> 118 | return this.gridPom.page.waitForFunction(
| ^
119 | (text_) => {
120 | return (
121 | document.querySelector("[data-cy='entry-counts']").textContent ===
at GridAsserter.isEntryCountTextEqualTo (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/grid/index.ts:118:30)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/groups/sparse-groups.spec.ts:103:23
|
[chromium] › oss/specs/groups/sparse-groups.spec.ts:54:3 › png default slice:
e2e-pw/src/oss/poms/modal/modal-sidebar.ts#L61
3) [chromium] › oss/specs/groups/sparse-groups.spec.ts:54:3 › png default slice ──────────────────
Error: expect(received).toBe(expected) // Object.is equality
Expected: "first"
Received: "second"
at oss/poms/modal/modal-sidebar.ts:61
59 | async verifySidebarEntryText(key: string, value: string) {
60 | const text = await this.modalSidebarPom.getSidebarEntryText(key);
> 61 | expect(text).toBe(value);
| ^
62 | }
63 |
64 | async verifySidebarEntryTexts(entries: { [key: string]: string }) {
at SidebarAsserter.verifySidebarEntryText (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/modal/modal-sidebar.ts:61:18)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/groups/sparse-groups.spec.ts:64:5
|
[chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › png second slice:
e2e-pw/src/oss/poms/grid/index.ts#L118
4) [chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › png second slice ───────────────────
TimeoutError: page.waitForFunction: Timeout 2000ms exceeded.
at oss/poms/grid/index.ts:118
116 |
117 | async isEntryCountTextEqualTo(text: string) {
> 118 | return this.gridPom.page.waitForFunction(
| ^
119 | (text_) => {
120 | return (
121 | document.querySelector("[data-cy='entry-counts']").textContent ===
at GridAsserter.isEntryCountTextEqualTo (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/grid/index.ts:118:30)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/groups/sparse-groups.spec.ts:103:23
|
[chromium] › oss/specs/regression-tests/grid-page.spec.ts:50:1 › modal group carousel has correct second page (all 21 samples):
e2e-pw/src/oss/specs/regression-tests/grid-page.spec.ts#L1
5) [chromium] › oss/specs/regression-tests/grid-page.spec.ts:50:1 › modal group carousel has correct second page (all 21 samples)
Test timeout of 60000ms exceeded.
|
[chromium] › oss/specs/regression-tests/grid-page.spec.ts:50:1 › modal group carousel has correct second page (all 21 samples):
e2e-pw/src/oss/fixtures/loader.ts#L163
5) [chromium] › oss/specs/regression-tests/grid-page.spec.ts:50:1 › modal group carousel has correct second page (all 21 samples)
Error: page.waitForSelector: Test timeout of 60000ms exceeded.
Call log:
- waiting for locator('[data-cy=flashlight-section]') to be visible
at oss/fixtures/loader.ts:163
161 | }
162 |
> 163 | await page.waitForSelector(
| ^
164 | `[data-cy=${withGrid ? "flashlight-section" : "panel-container"}]`,
165 | {
166 | state: "visible",
at OssLoader.waitUntilGridVisible (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/fixtures/loader.ts:163:16)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/grid-page.spec.ts:56:3
|
[chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:63:3 › groups video labels › correct thumbnails for both slices:
e2e-pw/src/oss/specs/regression-tests/group-video/group-video-label.spec.ts#L59
6) [chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:63:3 › groups video labels › correct thumbnails for both slices
Test timeout of 60000ms exceeded while running "beforeEach" hook.
57 | });
58 |
> 59 | test.beforeEach(async ({ page, fiftyoneLoader }) => {
| ^
60 | await fiftyoneLoader.waitUntilGridVisible(page, datasetName);
61 | });
62 |
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/group-video/group-video-label.spec.ts:59:8
|
[chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:63:3 › groups video labels › correct thumbnails for both slices:
e2e-pw/src/oss/fixtures/loader.ts#L163
6) [chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:63:3 › groups video labels › correct thumbnails for both slices
Error: page.waitForSelector: Test timeout of 60000ms exceeded.
Call log:
- waiting for locator('[data-cy=flashlight-section]') to be visible
at oss/fixtures/loader.ts:163
161 | }
162 |
> 163 | await page.waitForSelector(
| ^
164 | `[data-cy=${withGrid ? "flashlight-section" : "panel-container"}]`,
165 | {
166 | state: "visible",
at OssLoader.waitUntilGridVisible (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/fixtures/loader.ts:163:16)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/group-video/group-video-label.spec.ts:60:5
|
[chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice:
e2e-pw/src/oss/poms/modal/group-actions.ts#L92
7) [chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice
Error: expect(received).toBe(expected) // Object.is equality
Expected: "v1 is pinned"
Received: "v2 is pinned"
at oss/poms/modal/group-actions.ts:92
90 | async assertGroupPinnedText(text: string) {
91 | const pinnedText = await this.groupActionsPom.getGroupPinnedText();
> 92 | expect(pinnedText).toBe(text);
| ^
93 | }
94 |
95 | async assertIsCarouselVisible() {
at ModalGroupActionsAsserter.assertGroupPinnedText (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/modal/group-actions.ts:92:24)
at checkVideo (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/group-video/group-video-label.spec.ts:98:7)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/group-video/group-video-label.spec.ts:119:5
|
[chromium] › oss/specs/smoke-tests/quickstart.spec.ts:56:3 › quickstart › selection bookmark:
e2e-pw/src/oss/specs/smoke-tests/quickstart.spec.ts#L62
8) [chromium] › oss/specs/smoke-tests/quickstart.spec.ts:56:3 › quickstart › selection bookmark ──
Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected)
Locator: getByTestId('entry-counts')
Expected string: "1 sample"
Received string: "1 group of patch"
Call log:
- expect.toHaveText with timeout 5000ms
- waiting for getByTestId('entry-counts')
- locator resolved to <div data-cy="entry-counts" class="sc-heKikV idYoT">…</div>
- unexpected value "1 group of patch"
- locator resolved to <div data-cy="entry-counts" class="sc-heKikV idYoT">…</div>
- unexpected value "1 group of patch"
- locator resolved to <div data-cy="entry-counts" class="sc-heKikV idYoT">…</div>
- unexpected value "1 group of patch"
- locator resolved to <div data-cy="entry-counts" class="sc-heKikV idYoT">…</div>
- unexpected value "1 group of patch"
- locator resolved to <div data-cy="entry-counts" class="sc-heKikV idYoT">…</div>
- unexpected value "1 group of patch"
- locator resolved to <div data-cy="entry-counts" class="sc-heKikV idYoT">…</div>
- unexpected value "1 group of patch"
- locator resolved to <div data-cy="entry-counts" class="sc-heKikV idYoT">…</div>
- unexpected value "1 group of patch"
- locator resolved to <div data-cy="entry-counts" class="sc-heKikV idYoT">…</div>
- unexpected value "1 group of patch"
- locator resolved to <div data-cy="entry-counts" class="sc-heKikV idYoT">…</div>
- unexpected value "1 group of patch"
60 | await grid.actionsRow.bookmarkFilters();
61 | await gridRefresh;
> 62 | await expect(page.getByTestId("entry-counts")).toHaveText("1 sample");
| ^
63 | });
64 | });
65 |
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/quickstart.spec.ts:62:52
|
build / changes
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: dorny/paths-filter@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
test / test-app
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, codecov/codecov-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
build / build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-python@v4, actions/cache@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
test / test-python (ubuntu-latest-m, 3.8)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-python@v4, FedericoCarboni/setup-ffmpeg@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
test / test-python (ubuntu-latest-m, 3.8)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.10)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-python@v4, FedericoCarboni/setup-ffmpeg@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
test / test-python (ubuntu-latest-m, 3.10)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.11)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-python@v4, FedericoCarboni/setup-ffmpeg@v2, codecov/codecov-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
test / test-python (ubuntu-latest-m, 3.11)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "dist", "playwright-report".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
e2e / test-e2e
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, actions/cache@v3, FedericoCarboni/setup-ffmpeg@v2, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Slow Test:
e2e-pw/[chromium] › oss/specs/smoke-tests/saved-views.spec.ts#L1
e2e-pw/[chromium] › oss/specs/smoke-tests/saved-views.spec.ts took 49.5s
|
Slow Test:
e2e-pw/[chromium] › oss/specs/smoke-tests/field-visibility.spec.ts#L1
e2e-pw/[chromium] › oss/specs/smoke-tests/field-visibility.spec.ts took 46.0s
|
Slow Test:
e2e-pw/[chromium] › oss/specs/smoke-tests/quickstart-groups.spec.ts#L1
e2e-pw/[chromium] › oss/specs/smoke-tests/quickstart-groups.spec.ts took 21.3s
|
Slow Test:
e2e-pw/[chromium] › oss/specs/sidebar/sidebar.spec.ts#L1
e2e-pw/[chromium] › oss/specs/sidebar/sidebar.spec.ts took 16.5s
|
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only']
|
e2e / test-e2e
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only']
|
🎭 Playwright Run Summary
8 flaky
[chromium] › oss/specs/groups/sparse-groups-scenes.spec.ts:56:1 › ego default group slice transitions
[chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › mp4 second slice ────────────────────
[chromium] › oss/specs/groups/sparse-groups.spec.ts:54:3 › png default slice ───────────────────
[chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › png second slice ────────────────────
[chromium] › oss/specs/regression-tests/grid-page.spec.ts:50:1 › modal group carousel has correct second page (all 21 samples)
[chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:63:3 › groups video labels › correct thumbnails for both slices
[chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice
[chromium] › oss/specs/smoke-tests/quickstart.spec.ts:56:3 › quickstart › selection bookmark ───
1 skipped
91 passed (10.7m)
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
dist
Expired
|
15.5 MB |
|
playwright-report
Expired
|
15.6 MB |
|