[DONOTMERGE] Upgrade Disable rule to scalafix v1 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsargent
commented
Jan 13, 2023
| .map(Disable(index, _)) | ||
| override def withConfiguration(config: Configuration): Configured[Rule] = { | ||
| // should this use DisableConfig.default? | ||
| config.conf.getOrElse("disable", "Disable")(this.config).map { newConfig => Disable(newConfig) } |
wsargent
commented
Jan 13, 2023
| // errorCategory | ||
| // .copy(id = id) | ||
| // .at(message, pos) | ||
| DisableDiagnostic(symbol, details = details, position = pos) |
wsargent
commented
Jan 13, 2023
| isBlocked.findMatch(s).map { disabled => | ||
| SymbolOps.normalize(s) match { | ||
| case g: Symbol if g.info.get.signature.toString() != "<init>" => | ||
| Left(Patch.lint(DisableDiagnostic(s, "", t.pos)).atomic) // XXX this is incorrect |
wsargent
commented
Jan 13, 2023
| } | ||
|
|
||
| private def checkSynthetics(ctx: RuleCtx): Seq[Diagnostic] = { | ||
| // XXX what goes here? | ||
| private def checkSynthetics(implicit doc: SemanticDocument): Seq[Patch] = { |
There was a problem hiding this comment.
checkSynthetics I don't know what the v1 equivalent is
wsargent
commented
Jan 13, 2023
| @@ -33,7 +32,7 @@ case class DisabledSymbol( | |||
| def matches(symbol: Symbol): Boolean = { | |||
| this.symbol match { | |||
| case Some(s) => | |||
| SymbolOps.isSameNormalized(symbol, s) | |||
| symbol.normalized.equals(s.normalized) | |||
wsargent
commented
Jan 13, 2023
| @@ -53,10 +52,14 @@ object DisabledSymbol { | |||
| } else { | |||
| msg | |||
| } | |||
|
|
|||
| implicit lazy val symbolV1Reader: ConfDecoder[Symbol] = | |||
There was a problem hiding this comment.
best guess at what Symbol.Global equivalent is
wsargent
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE, STILL BEING WORKED ON
This is a PR to upgrade the Disable scalafix rule from scalafix v0 to scalafix v1.