-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JS support #22
Comments
Hey, any update on JS support? |
Hey @utkarsh-agrawaal, the news is as follows: |
Hey @elena-lyulina , any update on JS support? |
Hey @HaseebLUMS, |
@elena-lyulina When should I expect to see JS parser publicly released? |
@HaseebLUMS |
Hello @egor-bogomolov |
@HaseebLUMS I will review parser's code tonight. |
@egor-bogomolov |
@HaseebLUMS hope so :) |
@egor-bogomolov Hi, how's it going? |
@egor-bogomolov @elena-lyulina I would like to know whats the current status of JS support with astminer? Any plan when JS will be supported with astminer? |
@egor-bogomolov I have attempted to use it with the following sample input: example: execution: Output files: tokens.csv
node_types.csv
paths.csv
path_contexts.csv A couple of pertinent questions:
I would also be curious to know how to make the path output more closer to AST i.e. the output without comma, parenthesis. Also AST output from Esprima illustrating the problem: I am happy to contribute to the repo as required. |
Hi! Storing parenthesis, commas, etc. is strange. But I think this is predefined by ANTLR4 grammar which we use for JS. Maybe there are some parameters for generating rules inside ANTLR4 to set up the way of parsing... Btw, did you try to run the astminer on more complex examples? For example on some functions? Speaking about changing ids back to words in paths, it's completely unnecessary. You already can feed this data in code2vec. You need this back conversion only on inference, to produce readable output to users. |
@nashid, you don't see the As @SpirinEgor mentioned, all the non-alphanumeric tokens (like @SpirinEgor I guess we need to work on the configuration so that we can automatically ignore such tokens and corresponding contexts. |
Since JavaScript was added and there are no questions at this moment I will close the issue. But feel free to open at any time if you have ones. |
Add JS support via
The text was updated successfully, but these errors were encountered: