Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JS to CLI #123

Merged
merged 2 commits into from
Feb 19, 2021
Merged

Add JS to CLI #123

merged 2 commits into from
Feb 19, 2021

Conversation

egor-bogomolov
Copy link
Collaborator

We have both parsing and method splitting for JS implemented for quite some time but they never made it to the CLI. It's time to add them.
I tested the code2vec and parse tasks with file and method granularity on a small JS repo, they seem to work fine.

Copy link
Contributor

@SpirinEgor SpirinEgor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vovak vovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!

@vovak vovak merged commit bf949e5 into master-dev Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants